Thanks Francis! -- Michael Mior mm...@apache.org
Le dim. 2 déc. 2018 à 21:13, Francis Chuang <francischu...@apache.org> a écrit : > Avatica 1.13.0 has been tagged and released. I am holding off the formal > announcement until the release artifacts propagate across all mirrors. > > The Hypersql docker image was also published successfully using docker > hub hooks: > - https://hub.docker.com/r/apache/calcite-avatica/ > - https://hub.docker.com/r/apache/calcite-avatica-hypersql/ > > On 29/11/2018 8:21 am, Francis Chuang wrote: > > Good catch, Julian! I've updated the commit to remove the comment. > > > > On 29/11/2018 4:41 am, Julian Hyde wrote: > >> In docker/src/main/dockerhub/Dockerfile, is the comment line > >> > >> # This line must be preserved. The Maven build will verify this > >> version matches its version > >> > >> still accurate? > >> > >>> On Nov 28, 2018, at 2:12 AM, Francis Chuang > >>> <francischu...@apache.org> wrote: > >>> > >>> Hey all, > >>> > >>> If there are no objections, I plan to merge my PR for CALCITE-2698 > >>> [1] in around 12 hours time and make rc0 available for voting. > >>> > >>> Francis > >>> > >>> [1] https://github.com/apache/calcite-avatica/pull/79 > >>> > >>> On 24/11/2018 1:03 pm, Julian Hyde wrote: > >>>> Great, thanks. Just wanted to make sure I wasn’t they only one > >>>> seeing this. > >>>> > >>>>> On Nov 23, 2018, at 6:00 PM, Francis Chuang > >>>>> <francischu...@apache.org> wrote: > >>>>> > >>>>> `mvn site` should work correctly once my PR for CALCITE-2698 is > >>>>> merged. > >>>>> > >>>>> `mvn site` broke because my fix for CALCITE-2385 required > >>>>> -DskipDockerCheck to be appended to all invocations of `mvn`. The > >>>>> fix for CALCITE-2698 removes this check and allows docker hub to > >>>>> pass the avatica version to be used to the dockerfile directly > >>>>> during a build. > >>>>> > >>>>> On 24/11/2018 5:41 am, Julian Hyde wrote: > >>>>>> Are you aware that “mvn site” has been broken for several days? > >>>>>> > >>>>>> [ERROR] Failed to execute goal > >>>>>> org.apache.maven.plugins:maven-site-plugin:3.7.1:site > >>>>>> (default-site) on project avatica-parent: failed to get report > >>>>>> for org.apache.maven.plugins:maven-javadoc-plugin: Failed to > >>>>>> execute goal org.codehaus.gmaven:groovy-maven-plugin:2.1:execute > >>>>>> (check-dockerhub-dockerfile-version) on project avatica-docker: > >>>>>> Execution check-dockerhub-dockerfile-version of goal > >>>>>> org.codehaus.gmaven:groovy-maven-plugin:2.1:execute failed: > >>>>>> Expected Avatica version of 1.13.0-SNAPSHOT but got 1.12.0 -> > >>>>>> [Help 1] > >>>>>> > >>>>>> > >>>>>>> On Nov 22, 2018, at 2:50 PM, Francis Chuang > >>>>>>> <francischu...@apache.org> wrote: > >>>>>>> > >>>>>>> I will be delaying the vote for rc0 for a few days as I would > >>>>>>> like to get CALCITE-2698 [1] into this release. This change will > >>>>>>> publish the avatica-hsqldb image to docker hub and allow the > >>>>>>> avatica-go integration tests to switch from my unofficial > >>>>>>> avatica-hsqldb image to the official image from Calcite. > >>>>>>> > >>>>>>> [1] https://issues.apache.org/jira/browse/CALCITE-2698 > >>>>>>> > >>>>>>> On 19/11/2018 8:39 am, Francis Chuang wrote: > >>>>>>>> Quick update for the release of Avatica 1.13.0. > >>>>>>>> > >>>>>>>> I was able to get releases and tests to build correctly in a > >>>>>>>> docker container. This is now committed to the repository as > >>>>>>>> docker-compose.yaml and docker.sh. The setup allows a committer > >>>>>>>> to start the release by running `docker-compose run -v > >>>>>>>> /c/Users/username/AppData/Roaming/gnupg:/.gnupg release`. The > >>>>>>>> script prompts the user for things like the release version and > >>>>>>>> so on and automatically sets up the environment in the > >>>>>>>> container. I feel that this drastically flattens the learning > >>>>>>>> curve for making an Avatica release and will be using it for > >>>>>>>> 1.13.0. I think it might also be useful for Calcite. > >>>>>>>> > >>>>>>>> In terms of the PRs on Github: > >>>>>>>> - INFRA just enabled Appveyor for the repository, so > >>>>>>>> CALCITE-2412 will be resolved and merged for this release soon. > >>>>>>>> - I wasn't able to reach Kevin Minder for CALCITE-2322[1]. It > >>>>>>>> does look like it is very close to being able to be merged. > >>>>>>>> Would anyone be interested in picking this up? We would still > >>>>>>>> keep Kevin's original commit, so that he gets credit for the > >>>>>>>> initial implementation. > >>>>>>>> - Michael and I tried to get in touch with the author of > >>>>>>>> PR#76[2], but we didn't hear back, so I don't think this will > >>>>>>>> make it into the release. > >>>>>>>> > >>>>>>>> There are also test failures on Travis and Jenkins, so I plan > >>>>>>>> to send another email to the list to start a discussion. > >>>>>>>> > >>>>>>>> If there are no objections, I plan to make rc0 available for > >>>>>>>> voting this Friday (23/11/2018) Australian Eastern Standard Time. > >>>>>>>> > >>>>>>>> Francis > >>>>>>>> > >>>>>>>> [1] https://github.com/apache/calcite-avatica/pull/49 > >>>>>>>> [2] https://github.com/apache/calcite-avatica/pull/76 > >>>>>>>> > >>>>>>>> On 14/11/2018 6:56 am, Francis Chuang wrote: > >>>>>>>>> Thanks for taking a look, Kevin! > >>>>>>>>> > >>>>>>>>> I'll try and see if I can get in touch with the Sergey and > >>>>>>>>> Kevin Minder to see if those PRs can make it into this release. > >>>>>>>>> > >>>>>>>>> Francis > >>>>>>>>> > >>>>>>>>> On 14/11/2018 2:15 am, Kevin Risden wrote: > >>>>>>>>>> I checked my PRs and they can't be merged yet for various > >>>>>>>>>> reasons. > >>>>>>>>>> CALCITE-2322 would be good to get in. CALCITE-2412 I think is > >>>>>>>>>> pretty close > >>>>>>>>>> just needs to be updated to current master. I checked on > >>>>>>>>>> Travis CI a few > >>>>>>>>>> weeks ago for Windows support and it didn't look like it had > >>>>>>>>>> everything > >>>>>>>>>> yet. I wouldn't move to it before this release. > >>>>>>>>>> > >>>>>>>>>> Kevin Risden > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> On Mon, Nov 12, 2018 at 4:40 PM Julian Hyde > >>>>>>>>>> <jh...@apache.org> wrote: > >>>>>>>>>> > >>>>>>>>>>> I don’t personally have an issue voting during thanksgiving > >>>>>>>>>>> week; after > >>>>>>>>>>> all, it’s just U.S, and it’s just 2 days. I don’t think you > >>>>>>>>>>> should back the > >>>>>>>>>>> release. If you can’t get enough votes, extend the voting > >>>>>>>>>>> period. > >>>>>>>>>>> > >>>>>>>>>>>> On Nov 12, 2018, at 1:30 PM, Francis Chuang > >>>>>>>>>>>> <francischu...@apache.org> > >>>>>>>>>>> wrote: > >>>>>>>>>>>> I have assigned my self to CALCITE-2576 (Release Avatica > >>>>>>>>>>>> 1.13) and will > >>>>>>>>>>> be release manager for this release, if there are no > >>>>>>>>>>> objections. > >>>>>>>>>>>> If possible, I'd like to have a release for voting > >>>>>>>>>>>> available by the end > >>>>>>>>>>> of next week (23/11/2018). Unfortunately, this is during > >>>>>>>>>>> Thanksgiving, but > >>>>>>>>>>> I am hoping that everyone will have the opportunity to test > >>>>>>>>>>> the release and > >>>>>>>>>>> cast a vote by the following week. Assuming rc0 passes, we > >>>>>>>>>>> can then make > >>>>>>>>>>> the release official by the end of that week (1/12/2018). > >>>>>>>>>>> This will then > >>>>>>>>>>> allow us to release Calcite 1.18 sometime in December, > >>>>>>>>>>> before Christmas. > >>>>>>>>>>>> Are there any issues/features you guys would like to see in > >>>>>>>>>>>> this release > >>>>>>>>>>> of Avatica? This is now the chance to get them into 1.13.0. > >>>>>>>>>>>> Francis > >>>>>>>>>>>> > >>>>>>>>>>>> On 12/11/2018 11:17 am, Julian Hyde wrote: > >>>>>>>>>>>>> A new release of Avatica would be great. And we would be > >>>>>>>>>>>>> able to use it > >>>>>>>>>>> in the upcoming Calcite, and upgrade Calcite’s version of > >>>>>>>>>>> Jetty. (See > >>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-2467.) > >>>>>>>>>>>>>> On Nov 11, 2018, at 2:42 PM, Francis Chuang > >>>>>>>>>>>>>> <francischu...@apache.org> > >>>>>>>>>>> wrote: > >>>>>>>>>>>>>> Hey all, > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> I want to start up some discussion to release Avatica > >>>>>>>>>>>>>> 1.13.0. It's > >>>>>>>>>>> been roughly 5 months since the last Avatica release and > >>>>>>>>>>> Kevin has made > >>>>>>>>>>> quite a few improvements to the code base. There are > >>>>>>>>>>> currently around 24 > >>>>>>>>>>> new commits since the last release. In addition, Jetty has > >>>>>>>>>>> also been > >>>>>>>>>>> upgraded, which I believe would be beneficial for Calcite. > >>>>>>>>>>>>>> I have a script to build Avatica releases using docker in > >>>>>>>>>>>>>> a branch and > >>>>>>>>>>> plan to merge it in for this release. I also want to fix > >>>>>>>>>>> CALCITE-2385 > >>>>>>>>>>> (Cannot build if we update the AVATICA_VERSION in the > >>>>>>>>>>> dockerfile during a > >>>>>>>>>>> dry-run release). > >>>>>>>>>>>>>> In terms of open PRs on Github: > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> - Kevin, can you see if your open PRs can make it into > >>>>>>>>>>>>>> this release? > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> - CALCITE-2412 to add appveyor for testing on Windows ( > >>>>>>>>>>> https://github.com/apache/calcite-avatica/pull/65) is > >>>>>>>>>>> currently in > >>>>>>>>>>> progress. Is there anything blocking us from merging this? > >>>>>>>>>>> Travis also > >>>>>>>>>>> released testing on Windows a month ago ( > >>>>>>>>>>> https://blog.travis-ci.com/2018-10-11-windows-early-release). > >>>>>>>>>>> Perhaps > >>>>>>>>>>> this is also an option we can look at. > >>>>>>>>>>>>>> - CALCITE-2322 didn't make it into 1.12.0. I'd like to > >>>>>>>>>>>>>> see if we can > >>>>>>>>>>> reengage Kevin Minder to get this in for 1.13.0 > >>>>>>>>>>>>>> - There's also an open PR that does not have a JIRA case: > >>>>>>>>>>> https://github.com/apache/calcite-avatica/pull/76 Let's see > >>>>>>>>>>> if we can > >>>>>>>>>>> shepherd this into the release. > >>>>>>>>>>>>>> Is there anyone on the list who would like to be release > >>>>>>>>>>>>>> manager? If > >>>>>>>>>>> no one is able to, I am happy to act as release manager for > >>>>>>>>>>> this release. > >>>>>>>>>>>>>> Francis > >>>>>>>>>>>>>> > > > >
