Hello, I've run the Hive tests and I've found something which might cause problems: in CALCITE-1413 we were extra cautious to not simplify cases like: CASE a=0 THEN 0 ELSE 1/a END and it worked correctly; however: RexProgramBuilder is also executes simplify - but the protection at that point is completely helpless: CASE $1 THEN $2 ELSE $3 END I've opened CALCITE-2731 Beyond this there are some new "redundant" IS TRUE checks and some extra casts which are probably appeared because of CALCITE-2726.
I was more thorough this time; so I don't think I'll be uncovering any more issues. Zoltan On 12/6/18 9:18 AM, Julian Hyde wrote:
OK, let's try again. I have created a build for Apache Calcite 1.18.0, release candidate 1. Thanks to everyone who has contributed to this release. Since RC 0, we have fixed the following issues: * [CALCITE-2726] ReduceExpressionRule oversimplifies filter conditions containing nulls * [CALCITE-2670] Combine similar JSON aggregate functions in operator table * [CALCITE-2468] Validator throws IndexOutOfBoundsException when trying to infer operand type from STRUCT return type (Rong Rong) You can read the release notes here: https://github.com/apache/calcite/blob/branch-1.18/site/_docs/history.md The commit to be voted upon: http://git-wip-us.apache.org/repos/asf/calcite/commit/06d0526e9e58b88bb6722ae3e66789b9e60a70d1 Its hash is 06d0526e9e58b88bb6722ae3e66789b9e60a70d1. The artifacts to be voted on are located here: https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.18.0-rc1 The hashes of the artifacts are as follows: src.tar.gz.sha256 88501d9c22c5cd28c2988a1f921fa112386ac819fb1dbcc5f68504b30b8d7dd7 A staged Maven repository is available for review at: https://repository.apache.org/content/repositories/orgapachecalcite-1050 Release artifacts are signed with the following key: https://people.apache.org/keys/committer/jhyde.asc Please vote on releasing this package as Apache Calcite 1.18.0. The vote is open for the next 108 hours (ending at 1pm Pacific on Mon 10th) and passes if a majority of at least three +1 PMC votes are cast. [ ] +1 Release this package as Apache Calcite 1.18.0 [ ] 0 I don't feel strongly about it, but I'm okay with the release [ ] -1 Do not release this package because... Here is my vote: +1 (binding) Julian
