Hi!

We are adding a new custom RelNode, that behaves a little bit like Aggregate 
node and we are wondering how we should implement 

RelNode#accept(org.apache.calcite.rex.RexShuttle)

Our node has a similar feature as Aggregate node, that it’s keying by the 
incoming data. At first I thought that this #accept() method should be 
implemented by applying the RexShuttle to all of the expressions that node is 
using internally (in our case key fields “expressions”/“references"), like it’s 
done in Join, Sort, Filter, …. But then I noticed that this method is not 
implemented for Aggregate node. So can we leave this method with the default 
implementation `return this;` as Aggregate node does it?

Thanks, Piotr Nowojski

Reply via email to