You removed this code:

-      } catch (Exception e) {
-        throw new RuntimeException(
-            "exception while executing [" + sql + "]", e);
-      }

Therefore the error stack from a test case that used to contain the SQL 
statement being run will no longer contain that SQL.

Julian


> On Feb 6, 2019, at 12:11 PM, Vladimir Sitnikov <[email protected]> 
> wrote:
> 
> Julian> This change is not an improvement.
> Julian> After this change, it is a little easier to see the assert
> (although it depends on how your IDE parses junit output) but the
> other information is no longer available
> 
> Hey Julian, thanks for reviewing the commit!
> 
> Would you please clarify which information is no longer available
> after the change?
> I really want a *precise* pointer to the information and/or a sample
> of a testcase as I can't really understand that from your mail.
> 
> Regards,
> Vladimir

Reply via email to