jacques-n commented on issue #980: [CALCITE-2736] Update the ReduceExpressionsRule to better expose options URL: https://github.com/apache/calcite/pull/980#issuecomment-461892376 @vlsi, sorry I didn't respond sooner, got caught up in some other things. I agree with avoidance of boolean when used as arguments, etc. In essence, the main part of what I'm doing here is exactly that. Using Enums is one way to solve this. Another option is using builder-esque pattern with an options object. I chose the second option because it benefits from being able to have additional options added without further refactoring. The only place where generic booleans are used are internal to the class and everything else is done via immutable builders well defined method names. As such, I don't think your requested changes make sense.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
