vlsi commented on issue #1024: [CALCITE-2817] Make CannotPlanException great URL: https://github.com/apache/calcite/pull/1024#issuecomment-462833580 Current exception message is very long, and it turns out Avatica duplicates the message (see https://github.com/apache/calcite-avatica/blob/3cfafde9f5f0f1fc3ddc60b5a4db19762c73b96b/core/src/main/java/org/apache/calcite/avatica/AvaticaConnection.java#L577-L578 ) This basically results in printing the brain dump twice. I'm inclined to put just a gist into the exception message, and attach planner dump as a separate `addSuppressed(new RuntimeException(...))` That would reduce the verbosity of the exception. In the mean time, we might want to remove `" + e.getMessage()` from Avatica to avoid duplication of exception messages.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
