asereda-gs commented on issue #1036: [CALCITE-2815] GeodeSchemaFactory change to pass in clientCache using jndi URL: https://github.com/apache/calcite/pull/1036#issuecomment-462852974 Commit title should be `[CALCITE-1234] Message (First Last)`. Your message is missing `(First Last)`. Also use imperative tone (_Address_) rather than paste tense (_Addressed_) (see [contributing](https://calcite.apache.org/develop/#contributing)). It looks like your merged messages from different commits and it is hard to understand what is the commit about. I would rather say `GeodeSchemaFactory change to lookup objects from JNDI`. I will come back about calcite SchemaFactory and JNDI (wherever it should be generically supported or not).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
