[GitHub] chadasa commented on a change in pull request #1036: [CALCITE-2815] GeodeSchemaFactory change to pass in clientCache using jndi

[GitBox]

chadasa commented on a change in pull request #1036: [CALCITE-2815] 
GeodeSchemaFactory change to pass in clientCache using jndi
URL: https://github.com/apache/calcite/pull/1036#discussion_r256260787
 
 

 ##########
 File path: 
geode/src/main/java/org/apache/calcite/adapter/geode/rel/GeodeSchemaFactory.java
 ##########
 @@ -39,18 +46,58 @@
   public static final String PDX_SERIALIZABLE_PACKAGE_PATH = 
"pdxSerializablePackagePath";
   public static final String ALLOW_SPATIAL_FUNCTIONS = "spatialFunction";
   public static final String COMMA_DELIMITER = ",";
+  public static final String JNDI_INITIAL_CONTEXT_FACTORY = 
"jndiInitialContextFactory";
+  public static final String JNDI_CLIENT_CACHE_OBJECT_KEY = 
"jndiClientCacheObjectKey";
 
   public GeodeSchemaFactory() {
     // Do Nothing
   }
 
+  private static Context getContext(Map map) {
+    Context context = null;
+
+    try {
+      String jndiInitialContextFactory = (String) 
map.get(JNDI_INITIAL_CONTEXT_FACTORY);
 
 Review comment:
   Will check for null and return null

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services