danny0405 commented on a change in pull request #1042: Avoid use of new
RuntimeException(e) in tests
URL: https://github.com/apache/calcite/pull/1042#discussion_r256713496
##########
File path: core/src/test/java/org/apache/calcite/test/CalciteAssert.java
##########
@@ -315,6 +305,7 @@ private Exception containsCorrectException(Throwable root)
{
assertThat(resultSetFormatter.string(), isLinux(expected));
} catch (SQLException e) {
throw new RuntimeException(e);
+ // TestUtil.rethrow(e);
}
Review comment:
Why just add a comment ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
