zhztheplayer commented on a change in pull request #1014: [CALCITE-2804] fix
casting to timestamps because of malformed dimensi…
URL: https://github.com/apache/calcite/pull/1014#discussion_r256784061
##########
File path:
druid/src/main/java/org/apache/calcite/adapter/druid/DruidExpressions.java
##########
@@ -159,7 +159,7 @@ public static String toDruidExpression(
}
public static String fromColumn(String columnName) {
- return DruidQuery.format("\"%s\"", columnName);
+ return DruidQuery.format("%s", columnName);
Review comment:
I did't run a test but I guess we may lose unicode identifier support here.
You can see how Druid handles unicode identifier from Druid expression's
grammer code[1] and the tree listener code[2].
[1]
https://github.com/apache/incubator-druid/blob/1f299408114d35a7101eb59fdcc3b6c9e30d8286/core/src/main/antlr4/org/apache/druid/math/expr/antlr/Expr.g4#L36
[2]
https://github.com/apache/incubator-druid/blob/1f299408114d35a7101eb59fdcc3b6c9e30d8286/core/src/main/java/org/apache/druid/math/expr/ExprListenerImpl.java#L315
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
