kgyrtkirk commented on a change in pull request #1042: Avoid use of new
RuntimeException(e) in tests
URL: https://github.com/apache/calcite/pull/1042#discussion_r256844438
##########
File path:
core/src/test/java/org/apache/calcite/sql/test/SqlOperatorBaseTest.java
##########
@@ -8153,7 +8154,7 @@ public TesterImpl(SqlTestFactory testFactory) {
} catch (RuntimeException e) {
throw e;
Review comment:
I think this catch "RuntimeException" is not needed; rethrow could be able
to handle that.
I was wondering...I usually prefer to throw Exception from test
methods/classes - but that change in this case seems to imply around 100
"throws Exception" additions :) so it might be better to leave it this way
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
