julianhyde commented on a change in pull request #1053: [CALCITE-2852]
Simplification: traverse calculations and unknown UDFs
URL: https://github.com/apache/calcite/pull/1053#discussion_r259510833
##########
File path: core/src/main/java/org/apache/calcite/rex/RexSimplify.java
##########
@@ -284,8 +284,24 @@ RexNode simplify(RexNode e, RexUnknownAs unknownAs) {
case NOT_EQUALS:
return simplifyComparison((RexCall) e, unknownAs);
default:
+ if (e.getClass() == RexCall.class) {
+ return simplifyGenericNode((RexCall) e);
Review comment:
...and, if and when we have that check, we should welcome bug reports of
conditions that breach that check. We might discover, for instance, that '- - -
- - - - - - - x' requires 1024 (2 ^ 10) simplify operations. That would be a
bug. But we might decide that it is a low priority bug, and not worth fixing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
