kgyrtkirk commented on a change in pull request #1032: CALCITE-2769: CSV
Adapter does not handle - Empty and malformed csv lines, space before or after
comma
URL: https://github.com/apache/calcite/pull/1032#discussion_r257633928
##########
File path:
example/csv/src/main/java/org/apache/calcite/adapter/csv/CsvEnumerator.java
##########
@@ -237,6 +241,9 @@ public void close() {
abstract E convertRow(String[] rows);
protected Object convert(CsvFieldType fieldType, String string) {
+ if (string != null) {
+ string = string.trim();
Review comment:
this would probably mean that a space value is not anymore considered a
value - it will be the same as an empty string
I think rfc4180 permits multiple spaces without quotes
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
