risdenk commented on a change in pull request #1031: CALCITE-2742: Update RexImpTable to use DataContext to retrieve USER and SYSTEM_USER URL: https://github.com/apache/calcite/pull/1031#discussion_r260897241
########## File path: core/src/main/java/org/apache/calcite/runtime/SqlFunctions.java ########## @@ -43,6 +43,7 @@ import org.apache.calcite.util.TimeWithTimeZoneString; import org.apache.calcite.util.TimestampWithTimeZoneString; +import com.google.common.base.Optional; Review comment: Do we need to use Guava here? Java 8 optional should work? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
