zhztheplayer commented on a change in pull request #1057: [CALCITE-2854] code
gen error for UNARY_MINUS operator call with deci…
URL: https://github.com/apache/calcite/pull/1057#discussion_r261215687
##########
File path: core/src/test/java/org/apache/calcite/test/ReflectiveSchemaTest.java
##########
@@ -625,6 +637,12 @@ private void check(ResultSetMetaData metaData, String
columnName,
private void checkOp(CalciteAssert.AssertThat with, String fn) {
for (Field field : EveryType.numericFields()) {
for (Field field2 : EveryType.numericFields()) {
+ //Decimal +-*/ others types has bug see CALCITE-2861
Review comment:
Two comments here:
1. I suggest to add a space after `//`.
2. Is using the word `arithmetic` better than `+-*/`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
