+1 (non-binding). Thank you for your hard work, Kevin.
Environment: MacOS. Maven 3.6.0. jdk1.8.0_181. mvn clean install - OK ./mvnw clean install - OK sh256 check - OK GPG check - OK Release notes - OK On Thu, Mar 21, 2019 at 5:20 PM Julian Hyde <[email protected]> wrote: > +1 (binding) > > Checked hashes, LICENSE, NOTICE, README, HISTORY.md, built and ran tests > using Ubuntu JDK 11, using both mvn and mvnw, ran rat. > > Thanks Kevin! > > Julian > > > > On Mar 21, 2019, at 5:05 AM, Enrico Olivelli <[email protected]> > wrote: > > > > great work Kevin > > > > +1 (non binding) > > checked signatures/checksum > > built from source on JDK11 (AdoptOpenJDK 11.0.2) on Linux, all tests > passed. > > > > all tests of downstream project HerdDB passed, 100% compatible, > > upgrading from 1.17.0 > > > > Regards > > Enrico > > > > > > Il giorno mer 20 mar 2019 alle ore 22:58 Francis Chuang > > <[email protected]> ha scritto: > >> > >> +1 (binding) > >> > >> Environment: maven:latest docker image (Maven 3.6.0, OpenJDK 11.0.2, > >> Debian stretch). > >> > >> Verified SHA256 hash - OK > >> Verified GPG signature - OK > >> Ran tests using ./mvnw -DskipTests clean install and ./mvnw test - OK > >> Checked history.md - OK > >> > >> Francis > >> > >> On 21/03/2019 5:05 am, Kevin Risden wrote: > >>> Hi all, > >>> > >>> I have created a build for Apache Calcite 1.19.0, release candidate 2. > >>> > >>> Thanks to everyone who has contributed to this release. > >>> > >>> Since RC 1, we have fixed the following issues: > >>> * [CALCITE-2929] Simplification of IS NULL checks are incorrectly > assuming > >>> that CAST-s are > >>> possible > >>> * [CALCITE-2931] Mongo Adapter- Compare Bson (not string) query > >>> representation in tests > >>> * [CALCITE-2932] Update stale Druid integration test cases > >>> > >>> You can read the release notes here: > >>> > https://github.com/apache/calcite/blob/branch-1.19/site/_docs/history.md > >>> > >>> The commit to be voted upon: > >>> > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=4143176acdb2860b3a80eb18e4cb1557f5969d13 > >>> > >>> Its hash is 4143176acdb2860b3a80eb18e4cb1557f5969d13. > >>> > >>> The artifacts to be voted on are located here: > >>> > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.19.0-rc2/ > >>> > >>> The hashes of the artifacts are as follows: > >>> src.tar.gz.sha256 > >>> 833fa3e9c97d8e89443f3b7a62fc6cce5f0e734836d82db1443425be6ac5dc65 > >>> > >>> A staged Maven repository is available for review at: > >>> > https://repository.apache.org/content/repositories/orgapachecalcite-1057/ > >>> > >>> Release artifacts are signed with the following key: > >>> https://people.apache.org/keys/committer/krisden.asc > >>> > >>> Please vote on releasing this package as Apache Calcite 1.19.0. > >>> > >>> The vote is open for the next 72 hours and passes if a majority of > >>> at least three +1 PMC votes are cast. > >>> > >>> [ ] +1 Release this package as Apache Calcite 1.19.0 > >>> [ ] 0 I don't feel strongly about it, but I'm okay with the release > >>> [ ] -1 Do not release this package because... > >>> > >>> Here is my vote: > >>> +1 (binding) > >>> > >>> Kevin Risden > >>> > >
