Francis Chuang, i have reviewed these 3 PRs and add some comments, hope can make some help for you.
Best, Danny Chan 在 2019年4月12日 +0800 AM6:48，Francis Chuang <[email protected]>，写道： > Just a quick update on the release process. I am planning to make rc0 > available for voting next Friday (19/4/2019) if possible. > > I know Kevin would like to get CALCITE-2983 in, so the timeline isn't > fixed and we can push rc0 out a little bit to get it in. > > In the meantime, can someone please review (and merge, if they are > ready) the following PRs? > - https://github.com/apache/calcite-avatica/pull/94 > - https://github.com/apache/calcite-avatica/pull/86 > - https://github.com/apache/calcite-avatica/pull/85 > > Francis > > On 9/04/2019 8:43 am, Francis Chuang wrote: > > Many thanks to reviewers for merging PRs and Kevin for upgrading Jetty. > > There's still CALCITE-2983 [1], but I think I can make rc0 available for > > voting soon. > > > > In the meantime, I'd like to get CALCITE-2882 in if I can hear back from > > the author: https://github.com/apache/calcite-avatica/pull/86 > > > > Vladimir, can you please take a look at Stamatis' review: > > https://github.com/apache/calcite-avatica/pull/85 > > > > Francis > > > > [1] https://issues.apache.org/jira/browse/CALCITE-2983 > > > > On 29/03/2019 8:41 am, Francis Chuang wrote: > > > Would anyone be interested in finishing CALCITE-2322 > > > (https://github.com/apache/calcite-avatica/pull/49)? > > > > > > There were some minor changes that were requested, but the original > > > author has disappeared. There does not appear to be any tests for the > > > change, but I am not sure how much work is required to finish the PR. > > > > > > A few comments about the other PRs: > > > - https://github.com/apache/calcite-avatica/pull/89 has been updated > > > and is ready for review > > > - https://github.com/apache/calcite-avatica/pull/86 is ready for > > > review, but might require more investigation > > > - https://github.com/apache/calcite-avatica/pull/85 no tests, but > > > maybe the change is not easy to test? > > > > > > Kevin: Do you think these can make it into the release? > > > - https://github.com/apache/calcite-avatica/pull/28 > > > - https://github.com/apache/calcite-avatica/pull/36 > > > > > > Francis > > > > > > On 27/03/2019 1:03 pm, Yuzhao Chen wrote: > > > > Thx for your work Francis, the PRs are not too many, I think the > > > > timeline is ok. > > > > > > > > Best, > > > > Danny Chan > > > > 在 2019年3月27日 +0800 AM5:19，Francis Chuang > > > > <[email protected]>，写道： > > > > > I am currently planning to make rc0 available for voting next Friday > > > > > (5 > > > > > April 2019). How does this sound? Does this leave enough time for > > > > > PRs to > > > > > get reviewed and other changes to be committed? > > > > > > > > > > If the proposed timeline is too tight, please let me know. > > > > > > > > > > Francis > > > > > > > > > > On 26/03/2019 8:54 am, Julian Hyde wrote: > > > > > > Thank you for stepping up! The release process - especially for > > > > > > Calcite, but also for Avatica and Avatica-Go - seems to be getting > > > > > > heavier these days, and it seems to be good to keep up momentum. > > > > > > > > > > > > I’ll review two or three of those PRs. I hope some other committers > > > > > > will step forward and take a few. > > > > > > > > > > > > Julian > > > > > > > > > > > > > > > > > > > On Mar 25, 2019, at 2:43 PM, Francis Chuang > > > > > > > <[email protected]> wrote: > > > > > > > > > > > > > > Hey all, > > > > > > > > > > > > > > Now that Kevin has finalized Calcite 1.19.0, I want to talk about > > > > > > > Avatica.The last release of Avatica was around 4 months ago and I > > > > > > > am happy to be release manager for 1.14.0. > > > > > > > > > > > > > > There are around 10 unreleased commits and 6 pretty fresh PRs that > > > > > > > I want to get into this release: > > > > > > > - https://github.com/apache/calcite-avatica/pull/82 > > > > > > > - https://github.com/apache/calcite-avatica/pull/85 > > > > > > > - https://github.com/apache/calcite-avatica/pull/86 > > > > > > > - https://github.com/apache/calcite-avatica/pull/88 > > > > > > > - https://github.com/apache/calcite-avatica/pull/89 > > > > > > > - https://github.com/apache/calcite-avatica/pull/90 > > > > > > > > > > > > > > If anyone has spare cycles to review these PRs, please review > > > > > > > them, so we can get them in. > > > > > > > > > > > > > > I would like to get 1.14.0 out before the next Calcite release, so > > > > > > > that Calcite can use 1.14.0. Are there any others issues you guys > > > > > > > would like to be fixed? > > > > > > > > > > > > > > Once Avatica 1.14.0 is released, I will follow it with a release > > > > > > > of Avatica-Go. > > > > > > > > > > > > > > Francis > > > > > > > > > >
