Stamatis and Vova are both correct. As the fix is not ready to review, we should not hold the release for it; but if someone is prepared to work on a fix, we should help them move as fast as possible. That means stakeholders like me & Stamatis agreeing on a design and accepting a fix based on that design when it is ready.
I know it takes a lot of effort for Drill to stay current on Calcite, so we should support them in this effort. Julian > On May 21, 2019, at 2:55 PM, Stamatis Zampetakis <[email protected]> wrote: > > Hi Volodymyr, > > I am sharing your concern but I think we should avoid blocking the release > just for CALCITE-3055. > Since there is no consensus and no ongoing work it is unlikely that there > will be a fix reasonably soon. > Having said that, I am not in a particular rush for the release so if > others don't mind we can definitely wait for it. > > Best, > Stamatis > > > On Tue, May 21, 2019 at 5:29 PM Andrei Sereda <[email protected]> wrote: > >> I would like to include the following: >> >> [CALCITE-3023] Upgrade to Elasticsearch 7.0.0 >> [CALCITE-2913] Adapter for Apache Kafka >> [CALCITE-3027] Support like query in Elasticsearch >> >> Please note that ES upgrade (CALCITE-3023) is dropping support for types >> and is, potentially, backwards incompatible for ES adapter users which >> depend on types ( >> >> https://www.elastic.co/guide/en/elasticsearch/reference/7.0/removal-of-types.html >> ). >> >> >> On Tue, May 21, 2019 at 5:23 AM Vova Vysotskyi <[email protected]> wrote: >> >>> Hi all, >>> >>> Let's include CALCITE-3055 >>> <https://issues.apache.org/jira/browse/CALCITE-3055> into this release. >>> Though it is connected with dynamic tables and it is reproduced on >> 1.19.0, >>> but this issue breaks underlying projects, so I would treat it as a >> blocker >>> for the release. >>> Currently, there is no consensus on how it should be fixed. >>> >>> Kind regards, >>> Volodymyr Vysotskyi >>> >>> >>> On Mon, May 20, 2019 at 5:14 PM Stamatis Zampetakis <[email protected]> >>> wrote: >>> >>>> Regarding the issues where I am involved, I think the following can be >>>> finalized (and it would be nice to have) in the next two weeks: >>>> [CALCITE-2812] Add algebraic operators to allow expressing recursive >>>> [CALCITE-2969] Improve design of join-like relational expressions >> queries >>>> [CALCITE-2973] Allow theta joins that have equi conditions to be >> executed >>>> using a hash join algorithm >>>> [CALCITE-3037] Rename EnumerableThetaJoin to EnumerableNestedLoopJoin >> (It >>>> is done as part of CALCITE-2969) >>>> >>>> Other than that I have some doubts in general for CALCITE-3036, so I >>> don't >>>> think it is a good idea to include in this release (even if it is >>>> possible). >>>> >>>> >>>> >>>> >>>> On Mon, May 20, 2019 at 3:06 PM Michael Mior <[email protected]> wrote: >>>> >>>>> Just revisiting this now that the Avatica has been fixed. I have the >>>>> following list of pending JIRAs: >>>>> >>>>> [CALCITE-1581] UDTF like in hive >>>>> [CALCITE-2812] Add algebraic operators to allow expressing recursive >>>>> [CALCITE-2952] Certify Calcite on JDK 12 >>>>> [CALCITE-2969] Improve design of join-like relational expressions >>> queries >>>>> [CALCITE-2973] Allow theta joins that have equi conditions to be >>>>> executed using a hash join algorithm >>>>> [CALCITE-2992] Enhance implicit conversions when generating hash join >>>>> keys for an equi condition >>>>> [CALCITE-3036] Remove correlate variables from Join >>>>> [CALCITE-3037] Rename EnumerableThetaJoin to EnumerableNestedLoopJoin >>>>> >>>>> I think we should cut a release soon to keep momentum going. I'd like >>>>> to hear from those working on any of the JIRAs to see which ones >> could >>>>> be wrapped up in the next week or two. >>>>> -- >>>>> Michael Mior >>>>> [email protected] >>>>> >>>>> Le mar. 30 avr. 2019 à 11:15, Michael Mior <[email protected]> a >> écrit >>> : >>>>>> >>>>>> Calcite 1.19.0 was released approximately one month ago. This was >>>>>> later than we originally planned (although I think with good reason >>>>>> and I'm happy with what made it into this release). I don't think >>>>>> there's an imminent need for a new release, but I wanted to start >> the >>>>>> discussion now that Avatica has had it's latest release. >>>>>> >>>>>> There's a few big things in progress below that I thought I'd see >> if >>>>>> we want to try to include in the next release. Apologies if I >> missed >>>>>> any. >>>>>> >>>>>> CALCITE-1581 UDTF like in hive >>>>>> CALCITE-2952 Certify Calcite on JDK 12 >>>>>> CALCITE-3036 Remove correlate variables from Join >>>>>> CALCITE-3037 Rename EnumerableThetaJoin to EnumerableNestedLoopJoin >>>>>> >>>>>> -- >>>>>> Michael Mior >>>>>> [email protected] >>>>> >>>> >>> >>
