I think the support for recursive queries deserves top-billing alongside the Kafka adapter.
Since 3021 was added and then reverted I would remove it from the release notes. (I am inclined to remove any commits of an “Oops!” nature. If things were fixed/reverted before making it into a release, let’s pretend that they didn’t happen.) Julian > On Jun 13, 2019, at 11:11 AM, Michael Mior <[email protected]> wrote: > > Release notes are pushed to the branch-1.20 branch. Please review when > able. I did my best to sort things appropriately and highlight major > changes. If I missed some important work you or others did, please let > me know! > -- > Michael Mior > [email protected] > > Le jeu. 13 juin 2019 à 13:21, Michael Mior <[email protected]> a écrit : >> >> Sorry for the delay everyone. I'm currently working on rolling out >> rc0. Unfortunately I left my signing key at home so I might end up >> needing some help but I'm checking tests and putting together the >> changelog and other release material now. >> -- >> Michael Mior >> [email protected] >> >> Le lun. 10 juin 2019 à 18:54, Stamatis Zampetakis <[email protected]> a >> écrit : >>> >>> FYI: There are two new failures in our IT tests related with CALCITE-2804 >>> [1] and CALCITE-3120 [2]. >>> >>> Regarding CALCITE-2804 it seems that Hongze and Justin found out the >>> problem so it still remains to clarify CALCITE-3120. >>> >>> [1] https://issues.apache.org/jira/browse/CALCITE-2804 >>> [2] https://issues.apache.org/jira/browse/CALCITE-3120 >>> >>> On Mon, Jun 10, 2019 at 11:43 AM Bohdan Kazydub <[email protected]> >>> wrote: >>> >>>> Reverted CALCITE-2798 and added unit test in [1] for CALCITE-3121. >>>> If it is possible, please include this to Calcite 1.20. >>>> >>>> [1]https://github.com/apache/calcite/pull/1264 >>>> >>>> On Sat, Jun 8, 2019 at 2:30 AM Muhammad Gelbana <[email protected]> >>>> wrote: >>>> >>>>> I'll keep a close eye on those two PRs [1][2] in case anyone has further >>>>> comments. One of them [2] has been around for months now so I appreciate >>>> if >>>>> someone can finish reviewing it. Danny already pointed out some concerns >>>>> and I believe I addressed them. >>>>> >>>>> Thanks Michael for your recent comment. I fixed the typo. >>>>> >>>>> [1] https://github.com/apache/calcite/pull/1242 >>>>> [2] https://github.com/apache/calcite/pull/1066 >>>>> >>>>> Thanks, >>>>> Gelbana >>>>> >>>>> >>>>> On Fri, Jun 7, 2019 at 9:03 PM Michael Mior <[email protected]> wrote: >>>>> >>>>>> I'm not sure it can really be a blocker for the release since it's >>>>>> already been released. That said, we certainly would like to allow >>>>>> Drill the ability to upgrade. Since CALCITE-2798 isn't a functional >>>>>> change, I'd be open to reverting. >>>>>> -- >>>>>> Michael Mior >>>>>> [email protected] >>>>>> >>>>>> Le ven. 7 juin 2019 à 13:47, Bohdan Kazydub <[email protected]> >>>> a >>>>>> écrit : >>>>>>> >>>>>>> Hi all, >>>>>>> >>>>>>> I'm working on upgrading Calcite in Drill (from 1.18 to 1.20) and >>>>> almost >>>>>>> all issues were resolved except CALCITE-3121 >>>>>>> <https://issues.apache.org/jira/browse/CALCITE-3121>. >>>>>>> This issue appeared after the fix for CALCITE-2798 >>>>>>> <https://issues.apache.org/jira/browse/CALCITE-2798>, and it causes >>>> a >>>>>> lot >>>>>>> of queries to hang in Drill. >>>>>>> Sorry for reporting it so late, it was hard to reproduce it in >>>> Calcite. >>>>>>> >>>>>>> Since hanging of VolcanoPlanner is critical issue, I think it may be >>>> a >>>>>>> blocker for the release. >>>>>>> >>>>>>> Can we revert the fix for CALCITE-2798 >>>>>>> <https://issues.apache.org/jira/browse/CALCITE-2798> to resolve it >>>>>> before >>>>>>> the release, since the fix for more general one may require more >>>> time? >>>>>>> >>>>>>> Regards Bohdan >>>>>>> >>>>>>> >>>>>>> On Fri, Jun 7, 2019 at 7:41 PM Julian Hyde <[email protected]> wrote: >>>>>>> >>>>>>>> +1 >>>>>>>> >>>>>>>> I support fixing >>>> https://issues.apache.org/jira/browse/CALCITE-3119 >>>>> < >>>>>>>> https://issues.apache.org/jira/browse/CALCITE-3119> before 1.20 >>>>>> because >>>>>>>> it modifies APIs that we have added since 1.19; if we wait until >>>>> after >>>>>> the >>>>>>>> release, we will have to keep them. >>>>>>>> >>>>>>>> Browsing https://github.com/apache/calcite/pulls < >>>>>>>> https://github.com/apache/calcite/pulls> it looks likely that >>>> quite >>>>> a >>>>>> few >>>>>>>> PRs are ready. Committers, if you have a little time to review PRs >>>>> and >>>>>> find >>>>>>>> ones that you consider ready, put them in. If all they need is >>>>> cosmetic >>>>>>>> changes (e.g. an improved commit message, changes to formatting) >>>> feel >>>>>> free >>>>>>>> to make those fixups yourself. >>>>>>>> >>>>>>>> Julian >>>>>>>> >>>>>>>> >>>>>>>>> On Jun 7, 2019, at 8:06 AM, Michael Mior <[email protected]> >>>> wrote: >>>>>>>>> >>>>>>>>> I have reviewed and committed couple PRs and removed fix version >>>> of >>>>>>>>> 1.20.0 from all other issues. Given that it's Friday, I'm >>>> proposing >>>>>>>>> that I wait until Monday before freezing for release in case >>>> anyone >>>>>>>>> wants to push anything final through. >>>>>>>>> -- >>>>>>>>> Michael Mior >>>>>>>>> [email protected] >>>>>>>>> >>>>>>>>> Le ven. 31 mai 2019 à 20:03, Michael Mior <[email protected]> a >>>>>> écrit : >>>>>>>>>> >>>>>>>>>> Below is a link to open issues with fix version set to 1.20.0. I >>>>>>>>>> previously went through and removed the fix version for issues >>>>> which >>>>>>>>>> will definitely not be ready. >>>>>>>>>> >>>>>>>>>> >>>>>>>> >>>>>> >>>>> >>>> https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20status%20in%20(Open%2C%20%22In%20Progress%22)%20AND%20resolution%20%3D%20Unresolved%20AND%20fixVersion%20%3D%201.20.0%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC >>>>>>>>>> >>>>>>>>>> I don't think any of these are critical, but several have PRs >>>>> which >>>>>> I >>>>>>>>>> believe should be ready to merge. A second set of eyes would be >>>>>>>>>> appreciated. Some of the rest also have PRs but they seem to >>>> need >>>>>>>>>> further work. >>>>>>>>>> >>>>>>>>>> https://github.com/apache/calcite/pull/1138 >>>>>>>>>> https://github.com/apache/calcite/pull/1011 >>>>>>>>>> https://github.com/apache/calcite/pull/1014 >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> Michael Mior >>>>>>>>>> [email protected] >>>>>>>>>> >>>>>>>>>> Le ven. 31 mai 2019 à 14:28, Julian Hyde <[email protected]> a >>>>>> écrit : >>>>>>>>>>> >>>>>>>>>>> How are we doing? What must-fix bugs remain? >>>>>>>>>>> >>>>>>>>>>> I asked Danny to fix some deprecation warnings, which he duly >>>>>> did[1], >>>>>>>> but now I think I was mistaken, because he did so by removing a >>>> bunch >>>>>> of >>>>>>>> methods whose arguments were the now-deprecated class SemiJoin. >>>> This >>>>>> has >>>>>>>> become a breaking change with not even a minor release notice, and >>>> I >>>>>> think >>>>>>>> we should back it out before 1.20. I’m going to re-open 3102 and >>>>>> declare it >>>>>>>> a blocker for 1.20. Sorry I screwed up, Danny! Let’s discuss in the >>>>>> JIRA >>>>>>>> case. >>>>>>>>>>> >>>>>>>>>>> Julian >>>>>>>>>>> >>>>>>>>>>> [1] https://issues.apache.org/jira/browse/CALCITE-3102 < >>>>>>>> https://issues.apache.org/jira/browse/CALCITE-3102> >>>>>>>>>>> >>>>>>>>>>>> On May 28, 2019, at 5:18 AM, Yuzhao Chen < >>>> [email protected]> >>>>>>>> wrote: >>>>>>>>>>>> >>>>>>>>>>>> Thanks so much for your work, Michael, >>>>>>>>>>>> >>>>>>>>>>>> Let's get CALCITE-3055 into 1.20 version, because it fix an >>>>>>>> important function regression. I will merge it in if finishes the >>>>>> review. >>>>>>>>>>>> >>>>>>>>>>>> [1] https://github.com/apache/calcite/pull/1230/files >>>>>>>>>>>> >>>>>>>>>>>> Best, >>>>>>>>>>>> Danny Chan >>>>>>>>>>>> 在 2019年5月28日 +0800 AM1:41，Michael Mior <[email protected]>，写道： >>>>>>>>>>>>> Thanks Julian! I'm hoping we can get 1.20.0 out this week. I >>>>> did >>>>>> some >>>>>>>>>>>>> cleanup on JIRA and pinged a few for some status updates and >>>> I >>>>>> think >>>>>>>>>>>>> we're in reasonably good shape. >>>>>>>>>>>>> >>>>>>>>>>>>> -- >>>>>>>>>>>>> Michael Mior >>>>>>>>>>>>> [email protected] >>>>>>>>>>>>> >>>>>>>>>>>>> Le mar. 21 mai 2019 à 19:13, Julian Hyde <[email protected]> >>>> a >>>>>> écrit >>>>>>>> : >>>>>>>>>>>>>> >>>>>>>>>>>>>> I agree with Michael’s timeline “a week or two”. How about >>>>> code >>>>>>>> freeze on Friday 31st May, 10 days from now, and RC0 on Mon 3rd >>>> June? >>>>>>>>>>>>>> >>>>>>>>>>>>>> I have fixes for the following: >>>>>>>>>>>>>> >>>>>>>>>>>>>> * [CALCITE-3050] Integrate SqlDialect and SqlParser.Config >>>>>>>>>>>>>> * [CALCITE-3022] Babel: Various SQL parsing issues >>>>>>>>>>>>>> * [CALCITE-3047] In JDBC adapter, expose multiple schemas of >>>>> the >>>>>>>> back-end database >>>>>>>>>>>>>> * [CALCITE-3048] Improve how JDBC adapter deduces current >>>>>> schema on >>>>>>>> Redshift >>>>>>>>>>>>>> >>>>>>>>>>>>>> and I will commit them before the release. I will also help >>>>>>>>>>>>>> >>>>>>>>>>>>>> * [CALCITE-2969] Improve design of join-like relational >>>>>> expressions >>>>>>>> queries >>>>>>>>>>>>>> >>>>>>>>>>>>>> over the finishing line. >>>>>>>>>>>>>> >>>>>>>>>>>>>> Julian >>>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>>> On May 20, 2019, at 6:06 AM, Michael Mior < >>>> [email protected]> >>>>>>>> wrote: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Just revisiting this now that the Avatica has been fixed. I >>>>>> have >>>>>>>> the >>>>>>>>>>>>>>> following list of pending JIRAs: >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> [CALCITE-1581] UDTF like in hive >>>>>>>>>>>>>>> [CALCITE-2812] Add algebraic operators to allow expressing >>>>>>>> recursive >>>>>>>>>>>>>>> [CALCITE-2952] Certify Calcite on JDK 12 >>>>>>>>>>>>>>> [CALCITE-2969] Improve design of join-like relational >>>>>> expressions >>>>>>>> queries >>>>>>>>>>>>>>> [CALCITE-2973] Allow theta joins that have equi conditions >>>> to >>>>>> be >>>>>>>>>>>>>>> executed using a hash join algorithm >>>>>>>>>>>>>>> [CALCITE-2992] Enhance implicit conversions when generating >>>>>> hash >>>>>>>> join >>>>>>>>>>>>>>> keys for an equi condition >>>>>>>>>>>>>>> [CALCITE-3036] Remove correlate variables from Join >>>>>>>>>>>>>>> [CALCITE-3037] Rename EnumerableThetaJoin to >>>>>>>> EnumerableNestedLoopJoin >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> I think we should cut a release soon to keep momentum >>>> going. >>>>>> I'd >>>>>>>> like >>>>>>>>>>>>>>> to hear from those working on any of the JIRAs to see which >>>>>> ones >>>>>>>> could >>>>>>>>>>>>>>> be wrapped up in the next week or two. >>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>> Michael Mior >>>>>>>>>>>>>>> [email protected] >>>>>>>>>>>>>>> >>>>>>>>>>>>>>> Le mar. 30 avr. 2019 à 11:15, Michael Mior < >>>> [email protected] >>>>>> >>>>>> a >>>>>>>> écrit : >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> Calcite 1.19.0 was released approximately one month ago. >>>>> This >>>>>> was >>>>>>>>>>>>>>>> later than we originally planned (although I think with >>>> good >>>>>>>> reason >>>>>>>>>>>>>>>> and I'm happy with what made it into this release). I >>>> don't >>>>>> think >>>>>>>>>>>>>>>> there's an imminent need for a new release, but I wanted >>>> to >>>>>> start >>>>>>>> the >>>>>>>>>>>>>>>> discussion now that Avatica has had it's latest release. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> There's a few big things in progress below that I thought >>>>> I'd >>>>>> see >>>>>>>> if >>>>>>>>>>>>>>>> we want to try to include in the next release. Apologies >>>> if >>>>> I >>>>>>>> missed >>>>>>>>>>>>>>>> any. >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> CALCITE-1581 UDTF like in hive >>>>>>>>>>>>>>>> CALCITE-2952 Certify Calcite on JDK 12 >>>>>>>>>>>>>>>> CALCITE-3036 Remove correlate variables from Join >>>>>>>>>>>>>>>> CALCITE-3037 Rename EnumerableThetaJoin to >>>>>>>> EnumerableNestedLoopJoin >>>>>>>>>>>>>>>> >>>>>>>>>>>>>>>> -- >>>>>>>>>>>>>>>> Michael Mior >>>>>>>>>>>>>>>> [email protected] >>>>>>>>>>>>>> >>>>>>>>>>> >>>>>>>> >>>>>>>> >>>>>> >>>>> >>>>
