I believe we stopped releasing zips a while back in CALCITE-2333[1], so
the gradle task needs to be updated to not build any zip files.
In past releases (1.15.0-rc0), we also provided a hash of the signature:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.15.0-rc0/apache-calcite-avatica-1.15.0-src.tar.gz.asc.sha512.
It appears this is missing as well.
According to
https://github.com/vlsi/vlsi-release-plugins/tree/master/plugins/stage-vote-release-plugin,
the -Prelease flag specifies if the build is a release or a snapshot. I
am not sure what it does behind the scenes, but I have always used
gradle test to run the tests in docker.
In the past, I've included a note for running tests in Docker so that
it's not necessary to dig through the docs and howtos [2]. Should this
be removed as well?
Francis
[1]https://issues.apache.org/jira/browse/CALCITE-2333
[2]https://lists.apache.org/thread.html/5d2403063ddc52697e9df5c7fd80f004972fcb487bbf76c2759eccaf%40%3Cdev.calcite.apache.org%3E
On 10/12/2019 12:26 pm, Julian Hyde wrote:
+0
I’m curious why the instructions include ‘-Prelease’. People should be able to
unpack and build the distribution and do a ’normal’ build.
Sure, it is useful to be able to reproduce the release build, but it’s much
more important that a normal build works.
And, related, I would not include build instructions in the vote email. The
distribution should be self-describing.
Julian
On Dec 9, 2019, at 5:23 PM, Kevin Risden <[email protected]> wrote:
-1
"./gradlew build -Prelease -PskipSigning" fails on the zip when extracted.
Looks like it has windows line endings and doesn't pass checks.
Looks like we are publishing both tar.gz and zip now?
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.16.0-rc0/
We
didn't do that in the past just the .tar.gz.
I'd prefer if we removed the zip publishing and went back to just tar.gz
which would alleviate the additional publishing and failing tests.
Checked the following:
* Commit hash passes tests with Docker and ./gradlew build -Prelease
-PskipSigning
* Checked signatures and hashes against tar.gz and zip
* Checked passes tests from tar.gz - ./gradlew build -Prelease -PskipSigning
* Checked tests in zip - this failed see above
* Checked staged Maven repo is complete
Kevin Risden
On Sun, Dec 8, 2019 at 5:17 PM Francis Chuang <[email protected]>
wrote:
Hi all,
I have created a build for Apache Calcite Avatica 1.16.0, release
candidate 0.
Thanks to everyone who has contributed to this release.
You can read the release notes here:
https://github.com/apache/calcite-avatica/blob/204d58849ecdf2ef639308edba74f416311f7d88/site/_docs/history.md
The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=204d58849ecdf2ef639308edba74f416311f7d88
Its hash is 204d58849ecdf2ef639308edba74f416311f7d88
Tag:
https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.16.0-rc0
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.16.0-rc0
(revision 37139)
The hashes of the artifacts are as follows:
b54066d3b67e1f47d8f3af74466155350bfa92e938f0f442383efd8abb49993c8aee3aca258a9cc2ebb347a6b2f9473c05221da52dd56971478e7989952a7393
*apache-calcite-avatica-1.16.0-src.tar.gz
0739d77ad6bfebd903ddd9fb72d03540f91676ec967ea0a0941e7b428f4045b9d7dab8803c499d3d681fd9c28a79a5feeb850eadcda46055174efc5e459b3661
*apache-calcite-avatica-1.16.0-src.zip
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1070/org/apache/calcite/
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/francischuang.asc
https://www.apache.org/dist/calcite/KEYS
N.B.
To create the jars and test Apache Calcite Avatica: "./gradlew build
-Prelease -PskipSigning".
If you do not have a Java environment available, you can run the tests
using docker. To do so, install docker and docker-compose, then run
"docker-compose run test" from the root of the directory.
Please vote on releasing this package as Apache Calcite Avatica 1.16.0.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite 1.16.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (binding)
Francis
