Ubuntu 18.04.3 LTS, jdk1.8.0_202, Gradle 6.0.1 * Checked signatures and checksums OK * Went over release note OK * Run build and tests (./gradlew clean build) on git repo OK * Run build and tests (./gradlew clean build) on staged sources OK * Run build and Calcite tests on Calcite current master (./gradlew clean build) with Avatica 1.16.0 OK * Run diff between staged sources and git commit (diff -qr apache-calcite-avatica-1.16.0-src ~/git/Apache/Avatica) ? Files apache-calcite-avatica-1.16.0-src/LICENSE and /home/zabetak/git/Apache/Avatica/LICENSE differ Only in apache-calcite-avatica-1.16.0-src: licenses
Minor remarks: There seems to be some differences regarding the licenses between the git repo and the staged sources. It seems that this is intended but I though it is worth mentioning. The release note has the full history of commits as usual but there are quite a few messages who are not self-contained and easy to understand. In general, maybe it would be better if we removed these commits from the release notes. +1 (binding) On Wed, Dec 11, 2019 at 11:20 PM Francis Chuang <francischu...@apache.org> wrote: > Hi all, > > I have created a build for Apache Calcite Avatica 1.16.0, release > candidate 1. > > Thanks to everyone who has contributed to this release. > > You can read the release notes here: > > https://github.com/apache/calcite-avatica/blob/512bbee4aa24ef9fb8106d0286d1243679dce2d0/site/_docs/history.md > > The commit to be voted upon: > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=512bbee4aa24ef9fb8106d0286d1243679dce2d0 > > Its hash is 512bbee4aa24ef9fb8106d0286d1243679dce2d0 > > Tag: > > https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.16.0-rc1 > > The artifacts to be voted on are located here: > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.16.0-rc1 > (revision 37181) > > The hashes of the artifacts are as follows: > > 102d3ab0e90dd1db5e012a966d265bdfa8a0f24f9016a4187a6e5f0135a14770da124493dd2c7a18c9d8d8b9af5ecf4f5aceb90d48421251f38bc6ce6f5be697 > *apache-calcite-avatica-1.16.0-src.tar.gz > > A staged Maven repository is available for review at: > > https://repository.apache.org/content/repositories/orgapachecalcite-1071/org/apache/calcite/ > > Release artifacts are signed with the following key: > https://people.apache.org/keys/committer/francischuang.asc > https://www.apache.org/dist/calcite/KEYS > > N.B. > To create the jars and test Apache Calcite Avatica: "./gradlew build > -PskipSigning". > > If you do not have a Java environment available, you can run the tests > using docker. To do so, install docker and docker-compose, then run > "docker-compose run test" from the root of the directory. > > Please vote on releasing this package as Apache Calcite Avatica 1.16.0. > > The vote is open for the next 72 hours and passes if a majority of at > least three +1 PMC votes are cast. > > [ ] +1 Release this package as Apache Calcite 1.16.0 > [ ] 0 I don't feel strongly about it, but I'm okay with the release > [ ] -1 Do not release this package because... > > > Here is my vote: > > +1 (binding) > > Francis >
