I did check the difference between the -shaded.jar (1.15.0) and .jar
(1.16.0) files on nexus yesterday and they seemed to be roughly the same
size, at least much bigger than the .jar files in (1.15.0).
My assumption is that they should be equivalent, but I would love to get
some confirmation first as releasing a broken 1.17.0 would cause more work.
On 20/12/2019 7:46 am, Kevin Risden wrote:
I haven't looked into this in detail yet, but can share details on one of
the questions:
- Can anyone confirm if the
avatica-standalone-server-${AVATICA_VERSION}-shaded.jar and
avatica-standalone-server-${AVATICA_VERSION}.jar.
jars are suppose to be equivalent?
The Maven built used the maven-shade-plugin to build a jar with all the
dependencies included. It could shaded dependencies if needed, but from
what I remember it was only for putting all the dependencies into a single
jar. Maven would typically leave the .jar alone and then would have a
-shaded.jar next to it with all the dependencies.
I don't know what the gradle build is doing in this case. The easiest way
to look is to see if the new .jar is close to the same size as the old
-shaded.jar. The new and old versions should be comparable on Nexus.
Kevin Risden
On Wed, Dec 18, 2019 at 9:59 PM Francis Chuang <[email protected]>
wrote:
Upon finalizing the release for Avatica 1.16.0, I noticed that the
dockerfiles would not build on docker hub. Upon investigation, it
appears that the file names of the jars on nexus has changed slightly.
The current dockerfiles [1] references
https://repository.apache.org/content/groups/public/org/apache/calcite/avatica/avatica-standalone-server/${AVATICA_VERSION}/avatica-standalone-server-${AVATICA_VERSION}-shaded.jar
Where as on nexus, they are now called
avatica-standalone-server-${AVATICA_VERSION}.jar.
- Can anyone confirm if the
avatica-standalone-server-${AVATICA_VERSION}-shaded.jar and
avatica-standalone-server-${AVATICA_VERSION}.jar.
jars are suppose to be equivalent?
- Since the docker images for 1.16.0 cannot be built, I think we ought
to fix the dockerfiles and release a 1.17.0.
Francis
[1]
https://github.com/apache/calcite-avatica/tree/master/docker/src/main/dockerhub