Sorry I would rather see it as not a regression, this is just our choice, if the plan changes: Either
• There is physical node in the logical plan which should be fixed • User Table does not implement a QueryableTable but a (ScannableTable | FilterableTable | ProjectableFilterableTable), but they still what a EnumerableTableScan, which is error prone for the reason I have illustrated in the EnumerableTableScan comments To fix this, change your plan to the correct one or implement your Table correctly. Best, Danny Chan 在 2020年2月26日 +0800 PM3:16，Stamatis Zampetakis <[email protected]>，写道： > Anton also mentioned a regression related with CALCITE-3769 [1]. I think we > should reach consensus for both CALCITE-3769 and CALCITE-3826 before moving > forward with the release. > > [1] https://issues.apache.org/jira/browse/CALCITE-3769 > > On Wed, Feb 26, 2020 at 8:10 AM Francis Chuang <[email protected]> > wrote: > > > Hey Enrico, > > > > If a regression was introduced and broke existing behavior and is not a > > breaking change, then it's probably something that we should fix before > > the release. > > > > Are you able to open a PR with a test case to confirm the bug so that it > > can be fixed? > > > > The release is running a bit late already, so hopefully this won't be a > > complicated fix. > > > > Francis > > > > On 26/02/2020 6:03 pm, Enrico Olivelli wrote: > > > Danny, > > > I have created https://issues.apache.org/jira/browse/CALCITE-3826 > > > for the problem about bind variables in UPDATE statements. > > > > > > I feel this it can be a serious regression that can lead to data > > > corruption (wrong data type in DML statements). > > > AFAICT There is no way to workaround the problem in the application, > > > because Calcite produces a wrong model for the query. > > > > > > It seems to be a regression introduced in > > > https://issues.apache.org/jira/browse/CALCITE-3672 but I am not sure. > > > we should confirm the bug and fix it or demonstrate that the bug is not > > valid > > > > > > -1 (non binding) > > > > > > Enrico > > > > > > Il giorno mer 26 feb 2020 alle ore 07:34 Feng Zhu > > > <[email protected]> ha scritto: > > > > > > > > Hi Danny, > > > > Thanks for your efforts. > > > > > > > > +1 (non-binding) > > > > > > > > Environment: Windows 7, JDK 1.8.0_121 > > > > - Build and Test (./gradlew build) - OK > > > > - Checked Release Notes - OK > > > > - Checked README - OK > > > > > > > > Best, > > > > Feng > > > > > > > > Danny Chan <[email protected]> 于2020年2月26日周三 下午1:23写道： > > > > > > > > > Hi all, > > > > > > > > > > I have created a build for Apache Calcite 1.22.0, release candidate 2. > > > > > > > > > > Thanks to everyone who has contributed to this release. > > > > > <Further details about release.> You can read the release notes here: > > > > > > > https://github.com/apache/calcite/blob/calcite-1.22.0/site/_docs/history.md > > > > > > > > > > The commit to be voted upon: > > > > > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e397e47b0752c0647590097584903a9561a646eb > > > > > > > > > > Its hash is e397e47b0752c0647590097584903a9561a646eb. > > > > > > > > > > The artifacts to be voted on are located here: > > > > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc2/ > > > > > > > > > > The hashes of the artifacts are as follows: > > > > > src.tar.gz.sha512 > > > > > > > > > > > > 049a7650645106589b8fa65adf36ebbe90accf8359bcc05f40d7b50b00df9327b24b189c4cd1c0e12a702635cc1dc41f9e8b60238073bf83dfcff9c0ef60e66a > > > > > *apache-calcite-1.22.0-src.tar.gz > > > > > > > > > > A staged Maven repository is available for review at: > > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1079 > > > > > > > > > > Release artifacts are signed with the following key: > > > > > https://people.apache.org/keys/committer/danny0405.asc > > > > > > > > > > Please vote on releasing this package as Apache Calcite 1.22.0. > > > > > > > > > > The vote is open for the next 72 hours and passes if a majority of > > > > > at least three +1 PMC votes are cast. > > > > > > > > > > [ ] +1 Release this package as Apache Calcite 1.22.0 > > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > > > [ ] -1 Do not release this package because... > > > > > > > > > > Here is my vote: > > > > > > > > > > +1 (binding) > > > > > > > > > > Best, > > > > > Danny Chan > > > > > > >
