Build tools generating/modifying source code is an anti-pattern. The LICENSE file is source code, because it is included in the source distribution.
It doesn’t matter whether our build tool is written in Gradle or MVS-360 assembly language. It is a tool and it needs to serve our interests. Julian > On Jun 18, 2020, at 4:27 PM, Stamatis Zampetakis <[email protected]> wrote: > > Ubuntu 18.04.4 LTS, jdk1.8.0_251, Gradle wrapper > > * Checked signatures and checksums OK > * Went over release note OK > * Built from git tag and run tests (./gradlew clean build) OK > * Built from source artifacts and run tests OK > * Built and run Calcite (./gradlew clean build) using the staged Maven > repository OK > * Checked diff between repo and artifacts (the file .editorconfig is in > git but not in artifacts) > > I think we have the same LICENSE differences that we have in Calcite the > past 2 releases and Vladimir said that it is intentional. > The missing .editorconfig file in the release artifacts is not crucial for > the release since I have the impression that after CALCITE-3623 it serves > no purpose. > I guess we can remove it afterwards. > > +1 (binding) > > Best, > Stamatis > > On Fri, Jun 19, 2020 at 12:40 AM Francis Chuang <[email protected]> > wrote: > >> Thanks for reviewing and voting on this release, Julian. >> >> Regarding 1, it looks like the LICENSE file in the source distro is >> generated during the gradle build, leading it to drift from the one >> committed in git. Vladimir, can you advise what's the best way to >> resolve this? >> >> For 3, I'll update the release history if/when the releases passes the >> vote and becomes final. >> >> Francis >> >> On 19/06/2020 6:16 am, Julian Hyde wrote: >>> +1 >>> >>> Checked signatures, L&N, compiled and ran tests on Ubuntu (JDK 14, Guava >> 29.0-jre) and (JDK 8, Guava 14.0), ran RAT. >>> >>> 1. I compared the git repo with the contents of the source distro. The >> LICENSE file was different. Not a blocker for release, but after release, >> please update the LICENSE file in git. >>> >>> 2. In order to run with versions of Guava 22.0 or higher I had to >> disable lots of license-checking code, using the following command line: >>> >>> ./gradlew clean build -x :tck:getLicenses -x :tck:license -x >> :tck:licenseCopySpec -x :standalone-server:getLicenses -x >> :standalone-server:license -x :standalone-server:licenseCopySpec >>> >>> Not a blocker for the release (since the default supported Guava is >> 14.0.1). I’ve logged https://issues.apache.org/jira/browse/CALCITE-4072 < >> https://issues.apache.org/jira/browse/CALCITE-4072>. >>> >>> 3. The release notes say it is tested on JDK 8 - 13 and Guava 14.0 - >> 23.0. It would be nice to declare that we go as far as JDK 14 and Guava >> 29.0-jre, which are the latest versions, and worked in my tests (after >> disabling license-checking tasks, as described above). >>> >>> Julian >>> >>> >>> >>> >>>> On Jun 16, 2020, at 6:01 PM, Francis Chuang <[email protected]> >> wrote: >>>> >>>> Hi all, >>>> >>>> I have created a build for Apache Calcite Avatica 1.17.0, release >>>> candidate 0. >>>> >>>> Thanks to everyone who has contributed to this release. >>>> >>>> You can read the release notes here: >>>> >> https://github.com/apache/calcite-avatica/blob/d56fcd004c68ca89c7e6aed2a86d46a9cb74f885/site/_docs/history.md >>>> >>>> The commit to be voted upon: >>>> >> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=d56fcd004c68ca89c7e6aed2a86d46a9cb74f885 >>>> >>>> Its hash is d56fcd004c68ca89c7e6aed2a86d46a9cb74f885 >>>> >>>> Tag: >>>> >> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.17.0-rc0 >>>> >>>> The artifacts to be voted on are located here: >>>> >> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.17.0-rc0 >>>> (revision 40054) >>>> >>>> The hashes of the artifacts are as follows: >>>> >> fc23b819485728df89a99e105480af1b4f2e972af7878d9c5f66d8b3e959ca240f3eef9c1588074d59b1fcb62afffbb27286e2106318b7c198f8e3b95c58956f >>>> *apache-calcite-avatica-1.17.0-src.tar.gz >>>> >>>> A staged Maven repository is available for review at: >>>> >> https://repository.apache.org/content/repositories/orgapachecalcite-1090/org/apache/calcite/ >>>> >>>> Release artifacts are signed with the following key: >>>> https://people.apache.org/keys/committer/francischuang.asc >>>> https://www.apache.org/dist/calcite/KEYS >>>> >>>> N.B. >>>> To create the jars and test Apache Calcite Avatica: "./gradlew build >> -Prelease -PskipSign". >>>> >>>> If you do not have a Java environment available, you can run the tests >>>> using docker. To do so, install docker and docker-compose, then run >>>> "docker-compose run test" from the root of the directory. >>>> >>>> Please vote on releasing this package as Apache Calcite Avatica 1.17.0. >>>> >>>> The vote is open for the next 72 hours and passes if a majority of at >>>> least three +1 PMC votes are cast. >>>> >>>> [ ] +1 Release this package as Apache Calcite 1.17.0 >>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release >>>> [ ] -1 Do not release this package because... >>>> >>>> >>>> Here is my vote: >>>> >>>> +1 (binding) >>>> >>>> Francis >>> >>> >>
