I agree with Julian. Not everybody has the option to run docker locally. Perhaps execute tests against embedded (or fake) instance as well as a real one (docker or externally managed) ? Like it is done in MongoDatabasePolicy.java [1]
Currently tests for Elasticsearch, Geode and Mongo are all run against embedded test instances but one should be able to execute them against a real one as well. https://github.com/apache/calcite/blob/master/mongodb/src/test/java/org/apache/calcite/adapter/mongodb/MongoDatabasePolicy.java#L70 [1] On Sun, Oct 18, 2020 at 3:30 AM Tugdual Grall <[email protected]> wrote: > Ok > > I will look more into it > > On Sun, Oct 18, 2020 at 8:54 AM Julian Hyde <[email protected]> > wrote: > > > This would be inconvenient for me personally. My company does not allow > me > > to run Docker on my work computer. > > > > Julian > > > > > On Oct 17, 2020, at 11:31 PM, Tugdual Grall <[email protected]> wrote: > > > > > > Hi > > > > > > I have created this PR to share with the community what could be done: > > > * https://github.com/apache/calcite/pull/2223 > > > > > > And associated issue > https://issues.apache.org/jira/browse/CALCITE-4344 > > > > > > I guess we will continue the discussion on the issue itself > > > > > > Tug > > > > > >> On Sat, Oct 17, 2020 at 11:05 PM Vladimir Sitnikov < > > >> [email protected]> wrote: > > >> > > >> Tugdual>Are we "allowed" to use containers in the tests, for example > > >> using TestContainers > > >> > > >> I believe Testcontainers-based tests are more than welcome, however, > > >> nobody implemented that yet. > > >> It would be great if you could contribute that. > > >> > > >> Vladimir > > >> > > >> > > >
