Liya Fan created CALCITE-4350:
---------------------------------
Summary: The reverse operation of collation direction is overly
relaxed
Key: CALCITE-4350
URL: https://issues.apache.org/jira/browse/CALCITE-4350
Project: Calcite
Issue Type: Improvement
Components: core
Reporter: Liya Fan
Assignee: Liya Fan
For the current implementation, {{RelFieldCollation#Direction#reverse}} returns
\{{DESCENDING}} for \{{STRICTLY_ASCENDING}}, and returns \{{ASCENDING}} for
{{STRICTLY_DESCENDING}}.
This is overly relaxed. In a strict manner, it should return
\{{STRICTLY_DESCENDING}} for \{{STRICTLY_ASCENDING}}, and vice versa.
If the user needs to get the relaxed reverse direction, they may call
\{{collation.getDirection().reverse().lax();}}, as in many places of our code
base.
Do you agree?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
