Stamatis Zampetakis created CALCITE-4570:
--------------------------------------------
Summary: Always validate preconditions in Filter, Correlate,
Snapshot expressions when assertions are enabled
Key: CALCITE-4570
URL: https://issues.apache.org/jira/browse/CALCITE-4570
Project: Calcite
Issue Type: Improvement
Reporter: Stamatis Zampetakis
Assignee: Stamatis Zampetakis
At the moment precondition validation is performed in Filter, Correlate,
Snapshot constructors only when {{CalciteSystemProperty.DEBUG}} is true and
assertions are enabled.
Most of the time {{CalciteSystemProperty.DEBUG}} is set to false so the checks
are not performed which could lead to problems that are difficult to spot.
Failing fast when there is an obvious problem in the structure of the plan is a
great help for fixing issues that may also remain unnoticed for a very long
time.
The goal of this issue is to always validate preconditions in the constructor
of Filter, Correlate, and Snapshot regardless if
{{CalciteSystemProperty.DEBUG}} is enabled or not. To avoid the performance
overhead in production the assertions can be disabled as it usually happens.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
