Hi everyone, +1 (non-binding) after verifying the release as follows.
1) Checksum: OK 2) Signature: OK (same warning as Julien Hyde but that’s explained and makes sense) 3) Running tests: - “./gradlew build -Prelease -PskipSign”: OK (see JVM and OS details at the bottom) - “docker-compose run test”: OK - Check CI on github for the commit: OK A small error (coming from my original commit, apologies for not noticing before) in “history.md#50 <https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=blob;f=site/_docs/history.md;h=a81e77e042166457eb95d28d3cb3ce71e6867f80;hb=9486557be86bcade35d814d8a81be638395f57c6#l50> ”: java.lang.RuntimeException: java.lang.NoSuchFieldException: C should be java.lang.RuntimeException: java.lang.NoSuchFieldException: column Happy to re-verify once the current issue with the release procedure is resolved. $ java -version: openjdk version "1.8.0_265" OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_265-b01) OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.265-b01, mixed mode) $ sw_vers ProductName: Mac OS X ProductVersion: 10.15.7 BuildVersion: 19H524 Best regards, Alessandro On Fri, 9 Apr 2021 at 23:28, Julian Hyde <[email protected]> wrote: > I have logged https://issues.apache.org/jira/browse/CALCITE-4575 and > in it I propose that we exclude the Gradle wrapper (4 files) from the > source distribution. We would also need to amend build instructions in > site/_docs/howto.md. > > If ASF policy changes we can revisit, but we should not wait for that to > happen. > > The other issue with the release can be fixed by committing the > generated LICENSE file to Git. I have logged > https://issues.apache.org/jira/browse/CALCITE-4576 outlining the > problem and a possible solution. > > Julian > > On Fri, Apr 9, 2021 at 2:03 PM Stamatis Zampetakis <[email protected]> > wrote: > > > > There are various threads at @board, @legal-discuss and other places > where > > people are saying that Gradle wrapper jar is no exception to the rule and > > should be excluded from the releases. > > > > I understand that there disadvantages in removing the wrapper from our > > repos but doing that solves the debate and potential conflicts with > legal. > > > > If legal gives it's blessings to include the jar in the release then > great > > but I am afraid this will take time and freezing the release for this is > > not ideal. > > > > Best, > > Stamatis > > > > > > On Fri, Apr 9, 2021, 12:29 PM Vladimir Sitnikov < > [email protected]> > > wrote: > > > > > Stamatis, > > > > > > Thank you for the reference. > > > Cassandra case is vastly different: they included all the third-party > > > dependencies into the source package. > > > > > > However, in the thread you mention [1] there's a link that makes "build > > > tools" special: > > > https://apache.org/legal/resolved.html#build-tools > > > > > > That page explicitly permits the inclusion of the build tools if they > are > > > used for build purposes. > > > > > > The removal of gradle-wrapper.jar from the source release would reduce > > > security, and it would lower the release vote count > > > as the number of steps to build and verify the code increases. > > > > > > [1]: > > > > > > > https://lists.apache.org/thread.html/r1d7330da3c90eb4f2bb8555249572d85615c0f866b45ce04a30c00f2%40%3Cdev.cassandra.apache.org%3E > > > > > > Vladimir > > > >
