I will merge it.
On 2021/08/12 09:17:07, Taras Ledkov <tled...@gridgain.com> wrote: > Hi Calcite Devs. > > The patch for CALCITE-4652 [1] (see PR#2439 [2]) is reviewed and ready > for merge. > I'm looking for a committer to merge the patch. > > [1]. https://issues.apache.org/jira/browse/CALCITE-4652 > [2]. https://github.com/apache/calcite/pull/2439 > > On 10.08.2021 15:10, Taras Ledkov wrote: > > Hi Calcite Devs. > > > > I just remind about review/merge the patch for the issue CALCITE-4652 > > [1], see PR#2439 [2]. > > I've fixed the patch according with Julian comments. Also PR contains > > two 'LGTM' comments. > > Is the patch ready for merge? > > > > [1]. https://issues.apache.org/jira/browse/CALCITE-4652 > > [2]. https://github.com/apache/calcite/pull/2439 > > > > On 12.07.2021 15:05, xiong duan wrote: > >> Hi. Ledkov. I'll do some code reviews in the next two days. > >> > >> Taras Ledkov <tled...@gridgain.com> 于2021年7月12日周一 下午7:58写道： > >> > >>> Hi, > >>> > >>> Please review the patch for the issue CALCITE-4652 [1], see PR#2439 > >>> [2]. > >>> > >>> I tried to draw attention to the issue in the topic: > >>> "[HELP] Return type of the SUM aggregate function and > >>> AggregateExpandDistinctAggregatesRule", > >>> but did not receive any answer, so I do not give a link to the > >>> discussion. > >>> > >>> Stamatis advised me to send a reminder to the devlist. > >>> > >>> [1]. https://issues.apache.org/jira/browse/CALCITE-4652 > >>> [2]. https://github.com/apache/calcite/pull/2439 > >>> > >>> -- > >>> Taras Ledkov > >>> Mail-To: tled...@gridgain.com > >>> > >>> > -- > Taras Ledkov > Mail-To: tled...@gridgain.com > >
