Hi Arpit, Given that it has been a long time since the last review there are quite a few things that changed in Calcite. I would suggest rebasing the PR based on the current master and I will try to have another look.
Best, Stamatis On Mon, Sep 20, 2021 at 3:30 PM Arpit Motwani <[email protected]> wrote: > Hi Community, > > Please find below details of issue which we are facing in a pull request > raised by us for changes in ElasticsearchAdapters > > Issue Id- CALCITE-4232<https://issues.apache.org/jira/browse/CALCITE-4232> > > Above change has been accepted but is not merged upstream, is something > pending from our side ? > > Also, we see below error in PR of this change- > > This branch cannot be rebased due to conflicts > > Do we need to do something for the rebasing conflict? If yes kindly tell > us the approach for resolving this issue. > > Thanks & Regards > Arpit Motwani > > > ________________________________ > > > > > > > NOTE: This message may contain information that is confidential, > proprietary, privileged or otherwise protected by law. The message is > intended solely for the named addressee. If received in error, please > destroy and notify the sender. Any use of this email is prohibited when > received in error. Impetus does not represent, warrant and/or guarantee, > that the integrity of this communication has been maintained nor that the > communication is free of errors, virus, interception or interference. >
