Thanks for preparing this RC so quickly Julian!

Ubuntu 20.04.3 LTS, jdk1.8.0_261, Gradle wrapper, Gradle 6.8.3

 * Checked signatures and checksums OK
 * Went over release note OK
 * Built from git tag and run tests (./gradlew clean build) OK
 * Built from source artifacts and run tests (gradle clean build) OK
 * Inspected arbitrarily log4j classes in
avatica-standalone-server-1.20.0.jar (jar tf, jar xvf, javap) OK
Shading works, log4j2 is in use (not log4j v1.x), relocation is not done
(possibly a problem but was like that in previous releases)
 * Checked diff between repo and artifacts KO
There is an empty .trash directory in
apache-calcite-avatica-1.20.0-src.tar.gz which is not in the repo and I
think it shouldn't be there. I am not voting +1 due to this; leaving the
decision to the RM.

0 (binding)

Best,
Stamatis

On Sat, Dec 11, 2021 at 10:38 PM Jacques Nadeau <[email protected]> wrote:

> +1 (binding)
>
> Checked sig, checksum. Built and tested on macos/jdk8b302/gradle6.8.1.
>
> Thanks for being RM Julian.
>
> On Sat, Dec 11, 2021 at 1:30 PM Francis Chuang <[email protected]>
> wrote:
>
> > Thanks for being RM, Julian!
> >
> > My vote is: +1
> >
> > - Verified GPG signature - OK
> > - Verified SHA512 - OK
> > - Checked release notes on stage branch
> > (
> >
> https://github.com/apache/calcite-avatica/blob/stage/site/_docs/history.md
> )
> >
> > - OK
> > - Ran tests (gradle test) - OK
> > - Spot checked Nexus artifacts - OK
> >
> > Environment:
> > Gradle 6.9.1 docker container in WSL2 (Ubuntu 20.04) on Windows 10 21h2
> >
> >  > docker version
> > Client: Docker Engine - Community
> >   Cloud integration: v1.0.22
> >   Version:           20.10.11
> >   API version:       1.41
> >   Go version:        go1.16.9
> >   Git commit:        dea9396
> >   Built:             Thu Nov 18 00:37:33 2021
> >   OS/Arch:           linux/amd64
> >   Context:           default
> >   Experimental:      true
> >
> > Server: Docker Engine - Community
> >   Engine:
> >    Version:          20.10.11
> >    API version:      1.41 (minimum version 1.12)
> >    Go version:       go1.16.9
> >    Git commit:       847da18
> >    Built:            Thu Nov 18 00:35:39 2021
> >    OS/Arch:          linux/amd64
> >    Experimental:     false
> >   containerd:
> >    Version:          1.4.12
> >    GitCommit:        7b11cfaabd73bb80907dd23182b9347b4245eb5d
> >   runc:
> >    Version:          1.0.2
> >    GitCommit:        v1.0.2-0-g52b36a2
> >   docker-init:
> >    Version:          0.19.0
> >    GitCommit:        de40ad0
> >
> >  > gradle -v
> >
> > ------------------------------------------------------------
> > Gradle 6.9.1
> > ------------------------------------------------------------
> >
> > Build time:   2021-08-20 11:15:18 UTC
> > Revision:     f0ddb54aaae0e44f0a7209c3c0274d506ea742a0
> >
> > Kotlin:       1.4.20
> > Groovy:       2.5.12
> > Ant:          Apache Ant(TM) version 1.10.9 compiled on September 27 2020
> > JVM:          1.8.0_292 (AdoptOpenJDK 25.292-b10)
> > OS:           Linux 5.10.60.1-microsoft-standard-WSL2 amd64
> >
> >  > java -version
> > openjdk version "1.8.0_292"
> > OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_292-b10)
> > OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b10, mixed mode)
> >
> > Francis
> >
> > On 12/12/2021 7:04 am, Julian Hyde wrote:
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite Avatica 1.20.0, release
> > > candidate 0.
> > >
> > > Thanks to everyone who has contributed to this release.
> > >
> > > You can read the release notes here:
> > >
> >
> https://gitbox.apache.org/repos/asf/calcite-avatica-site-preview.git/avatica/docs/history.html
> > >
> > > The commit to be voted upon:
> > >
> >
> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=commit;h=8f8377551e7b07dbc6119ecf196942bc99834452
> > >
> > > Its hash is 8f8377551e7b07dbc6119ecf196942bc99834452
> > >
> > > Tag:
> > >
> >
> https://gitbox.apache.org/repos/asf?p=calcite-avatica.git;a=tag;h=refs/tags/avatica-1.20.0-rc0
> > >
> > > The artifacts to be voted on are located here:
> > >
> >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.20.0-rc0
> > > (revision 51334)
> > >
> > > The hashes of the artifacts are as follows:
> > >
> >
> 2de57fb1823237ec2d73f2e26059b6a7f5f51ec8f6dcfdcb2eb0b562cf4ef141c4a0a8c430610815e85b0b1c1c60245062cbb075c6dc72a44a4f543a6813bff2
> > > *apache-calcite-avatica-1.20.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1122/org/apache/calcite/
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/jhyde.asc
> > > https://www.apache.org/dist/calcite/KEYS
> > >
> > > To create the jars and test Apache Calcite Avatica: "gradle build
> > > -Prelease -PskipSign".
> > >
> > > If you do not have a Java/Gradle environment available, you can run the
> > tests
> > > using docker. To do so, install docker and docker-compose, then run
> > > "docker-compose run test" from the root of the directory.
> > >
> > > Please vote on releasing this package as Apache Calcite Avatica 1.20.0.
> > >
> > > The vote is open for the next 24 hours and passes if a majority of at
> > > least three +1 PMC votes are cast. (The voting period is shorter than
> > usual.)
> > >
> > > [ ] +1 Release this package as Apache Calcite Avatica 1.20.0
> > > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > >
> > > Here is my vote:
> > >
> > > +1 (binding)
> > >
> > > Julian
> >
>

Reply via email to