Hi, Julian. Your concern sounds reasonable, so I run some tests about those dependencies.
Adding "org.elasticsearch.plugin:elasticsearch-scripting-painless-spi” and removing “org.codelibs.elasticsearch.module:scripting-painless-spi”, the test results are OK. However, “org.codelibs.elasticsearch.module:lang-painless:7.15.2” are not available in Maven Central, while its latest version is 7.10.2. Since those dependencies are only used for unit tests, I lower down the above 2 dependencies to 7.10.2. Nevertheless, something wrong occurred when building Elasticsearch environment. PainlessPlugin cannot be loaded correctly, since QueryShardContext is renamed to SearchExecutionContext(see https://github.com/elastic/elasticsearch/pull/67490) after ES 7.12.0. Above all, it seems that we can’t upgrade Elasticsearch to 7.15.2 without adding a new repo, and the latest ES version we can reach is 7.10.2. Best, ZheHu On 2021/12/17 07:41:11 Julian Hyde wrote: > This is a useful change (just committed in > https://github.com/apache/calcite/commit/d6a36fc08715eba31d1d6bc26ef1ff5558d04b8d > > <https://github.com/apache/calcite/commit/d6a36fc08715eba31d1d6bc26ef1ff5558d04b8d>) > but it introduces a new package repository. > > Are we OK with that? > > The ConJars.org repository (which I introduced, years ago) was a pain to get > rid of. The repository went offline, and though we had stopped using it > several releases ago, it was still referenced in old Calcite releases. The > net effect was that Hive was unable to build. > > The lesson I learned was that a package repository is a long-term commitment. > If it’s not rock-solid and there for the long-term, we and dependent projects > are going to get suffer flaky and broken builds that we are powerless to fix. > > In my opinion, only two repositories can be bet upon long-term: Apache’s > repository and Maven Central. > > It looks as if the necessary module is in Maven Central: > https://search.maven.org/search?q=scripting-painless-spi > <https://search.maven.org/search?q=scripting-painless-spi>. > > Julian > > >> On Nov 23, 2021, at 6:36 AM, ZheHu (Jira) <[email protected]> wrote: >> >> ZheHu created CALCITE-4898: >> ------------------------------ >> >> Summary: Upgrading Elasticsearch version from 7.0.1 to 7.15 in >> Elasticsearch Adapter >> Key: CALCITE-4898 >> URL: https://issues.apache.org/jira/browse/CALCITE-4898 >> Project: Calcite >> Issue Type: Improvement >> Components: elasticsearch-adapter >> Affects Versions: 1.28.0 >> Reporter: ZheHu >> Assignee: ZheHu >> >> >> The current Elasticsearch version in Calcite is 7.0.1, while the latest >> released ES version is 7.15.2. >> >> There are many new SQL features added and bugs fixed from 7.0.1 to 7.15. By >> upgrading the embedded ES, we can make good use of ES's new features, >> especially about DSL, which enable developers to find one more suitable or >> effective way to implement features and improve existing functions. >> >> Since series of 7.x versions have good compatibility, this issue will just >> upgrade ES server without adjusting RestClient version in Elasticsearch >> Adapter. >> >> >> >> >> >> -- >> This message was sent by Atlassian Jira >> (v8.20.1#820001) >
