Liya, The PR has a couple of LGTMs, and it has passed my internal tests. I think you should cherry-pick it into master, revise release notes, and start a new RC. (Will require a small force-push.)
Julian On 2022/03/15 05:50:30 Fan Liya wrote: > Hi Julian, > > Thanks for your feedback and your PR. > > Best, > Liya Fan > > Julian Hyde <[email protected]> 于2022年3月15日周二 12:42写道： > > > I have a PR for [CALCITE-5040]. Please review > > https://github.com/apache/calcite/pull/2744 < > > https://github.com/apache/calcite/pull/2744>. > > > > Liya, Sorry I didn’t find time to vote on this RC. I reviewed the release > > notes and they look good. > > > > > On Mar 14, 2022, at 8:24 PM, Fan Liya <[email protected]> wrote: > > > > > > Thanks to everyone who has tested the release candidate and given > > > their comments and votes. > > > > > > The tally is as follows. > > > > > > 2 binding -1s: > > > Ruben, > > > Francis > > > > > > 2 non-binding +1s: > > > Liya, > > > Enrico > > > > > > 1 binding 0: > > > Stamatis > > > > > > Therefore, I think this release candidate should be rejected, until > > > CALCITE-5040 is resolved. > > > > > > Later, I will revert the release note commit > > > (170035fd97df1afdd0c0a499f63e0ca1606f7837, > > > maybe through git push force to master), and prepare another one after > > the > > > patch for > > > CALCITE-5040 is merged (if any). > > > > > > Thanks everyone. > > > > > > Liya Fan > > > > >
