Hello everyone,
thanks a lot Liya Fan for all the hard work on the release and for
battle-testing our process documentation which is very important.

My vote is +1 (non-binding), tested as follows:

- verified gpg signature: OK
$ curl "https://downloads.apache.org/calcite/KEYS"; | gpg --import
...
gpg: key 7F99D3070C037870: public key "Liya Fan (CODE SIGNING KEY) <
[email protected]>" imported

$ gpg --verify apache-calcite-1.30.0-src.tar.gz.asc.txt
apache-calcite-1.30.0-src.tar.gz
gpg: Signature made Wed 16 Mar 04:26:23 2022 CET
gpg:                using RSA key F90563572D7E336E0A0AD0957F99D3070C037870
gpg: Good signature from "Liya Fan (CODE SIGNING KEY) <[email protected]>"
[unknown]
gpg: WARNING: This key is not certified with a trusted signature!
gpg:          There is no indication that the signature belongs to the
owner.
Primary key fingerprint: F905 6357 2D7E 336E 0A0A  D095 7F99 D307 0C03 7870

(we agreed on previous releases that this warning is OK)

- verified package checksum: OK
$ diff <(cat apache-calcite-1.30.0-src.tar.gz.sha512.txt) <(shasum -a 512
apache-calcite-1.30.0-src.tar.gz)
1c1
<
6c9f65bcc75a05c226dbb0a74495e76761d738f6923086e2943fface1b8864697dff6d0de7aa0cb9b06f4f6aebe1322b5ecb829428f84d08c51dfb5773034040
*apache-calcite-1.30.0-src.tar.gz
---
>
6c9f65bcc75a05c226dbb0a74495e76761d738f6923086e2943fface1b8864697dff6d0de7aa0cb9b06f4f6aebe1322b5ecb829428f84d08c51dfb5773034040
 apache-calcite-1.30.0-src.tar.gz

- verified gradle build: OK
$ cp ~/git/calcite/gradlew .
$ cp -r ~/git/calcite/gradle/wrapper gradle
$ ./gradle build
...
BUILD SUCCESSFUL in 5m 25s

- checked release notes: OK
- checked few modules in Nexus: OK
- checking difference in folder: OK
$ diff -qr . ~/git/calcite | grep -v gradle | grep -v idea
(nothing worth mentioning)

- environment used:

$ sw_vers
ProductName: macOS
ProductVersion: 11.6
BuildVersion: 20G165

$ ./gradlew -version

------------------------------------------------------------
Gradle 7.3
------------------------------------------------------------

Build time:   2021-11-09 20:40:36 UTC
Revision:     96754b8c44399658178a768ac764d727c2addb37

Kotlin:       1.5.31
Groovy:       3.0.9
Ant:          Apache Ant(TM) version 1.10.11 compiled on July 10 2021
JVM:          1.8.0_292 (AdoptOpenJDK 25.292-b10)
OS:           Mac OS X 10.16 x86_64

$ java -version
openjdk version "1.8.0_292"
OpenJDK Runtime Environment (AdoptOpenJDK)(build 1.8.0_292-b10)
OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.292-b10, mixed mode)

Best regards,
Alessandro

On Wed, 16 Mar 2022 at 11:21, Ruben Q L <[email protected]> wrote:

> Thanks again Liya Fan for being the release manager in this
> particularly arduous one.
>
> My vote is: +1 (binding)
>
> - Checksum and signature: ok
> - Gradle test: ok (including the problematic one in isolation)
> - Calcite-based application test suite: ok
>
> Best,
> Ruben
>
>
> On Wed, Mar 16, 2022 at 5:01 AM Francis Chuang <[email protected]>
> wrote:
>
> > Thanks, Liya!
> >
> > My vote is: +1 (binding)
> >
> > - Verified GPG signature - OK
> > - Verified SHA512 - OK
> > - Checked release notes on tag
> > (
> >
> https://github.com/apache/calcite/blob/calcite-1.30.0-rc3/site/_docs/history.md
> )
> >
> > - OK
> > - Ran tests (gradle check) - OK
> > - Ran failing test in rc2 (gradle cleanTest :core:test --tests
> > SqlTypeFactoryTest.testUnknownCreateWithNullabilityTypeConsistency) - OK
> > - Spot checked Nexus artifacts - OK
> >
> > Environment:
> > Gradle 7.4.1 docker container in WSL2 (Ubuntu 20.04) on Windows 10 21h2
> >
> >  > docker version
> > Client: Docker Engine - Community
> >   Cloud integration: v1.0.22
> >   Version:           20.10.13
> >   API version:       1.41
> >   Go version:        go1.16.15
> >   Git commit:        a224086
> >   Built:             Thu Mar 10 14:08:15 2022
> >   OS/Arch:           linux/amd64
> >   Context:           default
> >   Experimental:      true
> >
> > Server: Docker Desktop
> >   Engine:
> >    Version:          20.10.13
> >    API version:      1.41 (minimum version 1.12)
> >    Go version:       go1.16.15
> >    Git commit:       906f57f
> >    Built:            Thu Mar 10 14:06:05 2022
> >    OS/Arch:          linux/amd64
> >    Experimental:     false
> >   containerd:
> >    Version:          1.5.10
> >    GitCommit:        2a1d4dbdb2a1030dc5b01e96fb110a9d9f150ecc
> >   runc:
> >    Version:          1.0.3
> >    GitCommit:        v1.0.3-0-gf46b6ba
> >   docker-init:
> >    Version:          0.19.0
> >    GitCommit:        de40ad0
> >
> >  > gradle -v
> >
> > ------------------------------------------------------------
> > Gradle 7.4.1
> > ------------------------------------------------------------
> >
> > Build time:   2022-03-09 15:04:47 UTC
> > Revision:     36dc52588e09b4b72f2010bc07599e0ee0434e2e
> >
> > Kotlin:       1.5.31
> > Groovy:       3.0.9
> > Ant:          Apache Ant(TM) version 1.10.11 compiled on July 10 2021
> > JVM:          17.0.2 (Eclipse Adoptium 17.0.2+8)
> > OS:           Linux 5.10.60.1-microsoft-standard-WSL2 amd64
> >
> >  > java -version
> > openjdk version "17.0.2" 2022-01-18
> > OpenJDK Runtime Environment Temurin-17.0.2+8 (build 17.0.2+8)
> > OpenJDK 64-Bit Server VM Temurin-17.0.2+8 (build 17.0.2+8, mixed mode,
> > sharing)
> >
> > Francis
> >
> > On 16/03/2022 2:36 pm, Fan Liya wrote:
> > > Hi all,
> > >
> > > I have created a build for Apache Calcite 1.30.0, release
> > > candidate 3.
> > >
> > > Thanks to everyone who has contributed to this release.
> > >
> > > You can read the release notes here:
> > >
> >
> https://github.com/apache/calcite/blob/calcite-1.30.0-rc3/site/_docs/history.md
> > >
> > > The commit to be voted upon:
> > >
> >
> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=cd5229b9a371e20de207231d55bcbddf1ff39ec2
> > >
> > > Its hash is cd5229b9a371e20de207231d55bcbddf1ff39ec2
> > >
> > > Tag:
> > > https://github.com/apache/calcite/tree/calcite-1.30.0-rc3
> > >
> > > The artifacts to be voted on are located here:
> > >
> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc3
> > > (revision 53122)
> > >
> > > The hashes of the artifacts are as follows:
> > >
> >
> 6c9f65bcc75a05c226dbb0a74495e76761d738f6923086e2943fface1b8864697dff6d0de7aa0cb9b06f4f6aebe1322b5ecb829428f84d08c51dfb5773034040
> > > *apache-calcite-1.30.0-src.tar.gz
> > >
> > > A staged Maven repository is available for review at:
> > >
> >
> https://repository.apache.org/content/repositories/orgapachecalcite-1153/org/apache/calcite/
> > >
> > > Release artifacts are signed with the following key:
> > > https://people.apache.org/keys/committer/COMMITTER_ID.asc
> > > https://www.apache.org/dist/calcite/KEYS
> > >
> > > To create the jars and test Apache Calcite: "gradle build"
> > > (requires an appropriate Gradle/JDK installation)
> > >
> > > Please vote on releasing this package as Apache Calcite 1.30.0.
> > >
> > > The vote is open for the next 72 hours and passes if a majority of at
> > > least three +1 PMC votes are cast.
> > >
> > > [ ] +1 Release this package as Apache Calcite 1.30.0
> > > [ ]  0 I don't feel strongly about it, but I'm okay with the release
> > > [ ] -1 Do not release this package because...
> > >
> > > Here is my vote:
> > >
> > > +1 (non-binding)
> > >
> > > Best,
> > > Liya Fan
> > >
> >
>

Reply via email to