Hi Abbas, It sounds reasonable but before doing so it would be nice to know the motivation behind the change that you want to perform.
Other than that if we are using the various suggesters interchangeably then it may make sense to unify them into one; didn't check the implications of doing so. Best, Stamatis On Thu, Jan 19, 2023 at 11:02 PM Abbas Gadhia <[email protected]> wrote: > Hi,I noticed that while converting from Sql to Rel in SqlToRelConverter, > the method deriveAlias is used which creates aliases of the type EXPR$0 > (when there is no specific alias assigned to an expression)However, if we > use RelBuilder.project_ , it creates aliases/field names using > SqlValidatorUtil.F_SUGGESTER. > It is apparent that F_SUGGESTER is used for deriving field names, however, > it also gets used for deriving names for unnamed expressions (in RelBuilder) > There are checks in SqlUtil.isGeneratedAlias that checks only the EXPR > aliases and not the $f aliases. > Question:Can we also additionally check $f aliases as part of the > SqlUtil.isGeneratedAlias check?Is there any specific background to $f > aliases that is not simply apparent? > > ThanksAbbas
