+1 (binding) Downloaded, checked NOTICE, README, LICENSE, README.md, howto.md; compared with git contents; checked headers (using rat); compiled and ran tests using OpenJDK 18 and Gradle 7.4.2 on Ubuntu Linux 5.9.0-29 x86_64.
I had some comments on the PR with the release notes but they can be fixed after the release. Thanks for being RM, Jess! Julian On Fri, Feb 3, 2023 at 10:36 AM Alessandro Solimando <[email protected]> wrote: > > Thanks Jess for preparing the RC, my vote is +1 (non-binding), tested as > follows: > > - verified gpg signature: OK > > $ gpg --verify apache-calcite-1.33.0-src.tar.gz.asc > apache-calcite-1.33.0-src.tar.gz > > gpg: Signature made Fri 03 Feb 2023 03:25:05 CET > > gpg: using RSA key EC3E70DF53363C76AAA7BEC0C09BA4E5B0A8BB04 > > gpg: Good signature from "Jess Balint <[email protected]>" [unknown] > > gpg: WARNING: This key is not certified with a trusted signature! > > gpg: There is no indication that the signature belongs to the > owner. > > Primary key fingerprint: EC3E 70DF 5336 3C76 AAA7 BEC0 C09B A4E5 B0A8 BB04 > > - verified package checksum: OK > > $ diff <(cat apache-calcite-1.33.0-src.tar.gz.sha512) <(shasum -a 512 > apache-calcite-1.33.0-src.tar.gz) > > 1c1 > > < > a4acc084344b48c1e9a61a70fbe8009c8093cafdb8c4f05d646681a5ea15ab79ab90b4c2fc7e410f952239a167001f4021e97c2c0be8f29edb7255015cb8a7c6 > *apache-calcite-1.33.0-src.tar.gz > > --- > > > > a4acc084344b48c1e9a61a70fbe8009c8093cafdb8c4f05d646681a5ea15ab79ab90b4c2fc7e410f952239a167001f4021e97c2c0be8f29edb7255015cb8a7c6 > apache-calcite-1.33.0-src.tar.gz > > - verified gradle build: OK > > $ cp ~/git/calcite/gradlew . > > $ cp -r ~/git/calcite/gradle/wrapper gradle > > $ ./gradlew build > > ... > > BUILD SUCCESSFUL in 9m 4s > > - checked release notes: OK (modulo comments in the PR) > > - checking difference in folder: OK > > - environment used: > > $ cat /etc/os-release > > PRETTY_NAME="Ubuntu 22.04.1 LTS" > > NAME="Ubuntu" > > VERSION_ID="22.04" > > VERSION="22.04.1 LTS (Jammy Jellyfish)" > > VERSION_CODENAME=jammy > > ID=ubuntu > > ID_LIKE=debian > > HOME_URL="https://www.ubuntu.com/"; > > SUPPORT_URL="https://help.ubuntu.com/"; > > BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"; > > PRIVACY_POLICY_URL=" > https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"; > > UBUNTU_CODENAME=jammy > > $ uname -r > > 5.15.0-58-generic > > $ ./gradlew -version > > ------------------------------------------------------------ > > Gradle 7.4.2 > > ------------------------------------------------------------ > > Build time: 2022-03-31 15:25:29 UTC > > Revision: 540473b8118064efcc264694cbcaa4b677f61041 > > Kotlin: 1.5.31 > > Groovy: 3.0.9 > > Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021 > > JVM: 1.8.0_352 (Azul Systems, Inc. 25.352-b08) > > OS: Linux 5.15.0-58-generic amd64 > > $ java -version > > openjdk version "1.8.0_352" > > OpenJDK Runtime Environment (Zulu 8.66.0.15-CA-linux64) (build > 1.8.0_352-b08) > > OpenJDK 64-Bit Server VM (Zulu 8.66.0.15-CA-linux64) (build 25.352-b08, > mixed mode) > > > On Fri, 3 Feb 2023 at 17:36, Ruben Q L <[email protected]> wrote: > > > Thanks Jess for producing this release. > > By the way, I think your vote should be counted as "non-binding" (probably > > just a copy-paste error). > > > > - Release notes: ok (considering the comments under the PR) > > - Checksum and signature: ok > > - Diff source release and git repository: ok > > - Build + tests: ok > > - Calcite-based application test suite: ok > > > > +1 (binding) > > > > Best regards, > > Ruben > > > > > > On Fri, Feb 3, 2023 at 11:11 AM Francis Chuang <[email protected]> > > wrote: > > > > > Thanks for being RM for this release, Jess! > > > > > > My vote is: +1 (binding) > > > > > > - Verified GPG signature - OK > > > - Verified SHA512 - OK > > > - Diffed source release and git repository - OK > > > - Checked release notes on tag > > > ( > > > > > https://github.com/apache/calcite/blob/calcite-1.33.0-rc0/site/_docs/history.md > > ) > > > > > > - OK > > > - Checked year in NOTICE, README and HOWTO - OK > > > - Ran tests (gradle check) - OK > > > - Spot checked Nexus artifacts - OK > > > > > > I noticed that the commit 96b05ee12 for the release is missing from the > > > main branch on GitHub, see the message on GitHub here: > > > > > > > > https://github.com/apache/calcite/commit/96b05ee12f936ed057265072ff6a2de8ea0a249e > > > > > > It is on the main branch in GitBox, > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=log;h=96b05ee12f936ed057265072ff6a2de8ea0a249e > > , > > > > > > so I think you just need to push that commit to main on GitHub. > > > > > > Environment: > > > Eclipse-temurin:17-jammy docker container in WSL2 (Ubuntu 22.04.1) on > > > Windows 11 22h2 > > > > > > > docker version > > > Client: Docker Engine - Community > > > Cloud integration: v1.0.29 > > > Version: 20.10.22 > > > API version: 1.41 > > > Go version: go1.18.9 > > > Git commit: 3a2c30b > > > Built: Thu Dec 15 22:28:22 2022 > > > OS/Arch: linux/amd64 > > > Context: default > > > Experimental: true > > > > > > Server: Docker Desktop > > > Engine: > > > Version: 20.10.22 > > > API version: 1.41 (minimum version 1.12) > > > Go version: go1.18.9 > > > Git commit: 42c8b31 > > > Built: Thu Dec 15 22:26:14 2022 > > > OS/Arch: linux/amd64 > > > Experimental: false > > > containerd: > > > Version: 1.6.14 > > > GitCommit: 9ba4b250366a5ddde94bb7c9d1def331423aa323 > > > runc: > > > Version: 1.1.4 > > > GitCommit: v1.1.4-0-g5fd4c4d > > > docker-init: > > > Version: 0.19.0 > > > GitCommit: de40ad0 > > > > > > >gradle -v > > > > > > ------------------------------------------------------------ > > > Gradle 7.4.2 > > > ------------------------------------------------------------ > > > > > > Build time: 2022-03-31 15:25:29 UTC > > > Revision: 540473b8118064efcc264694cbcaa4b677f61041 > > > > > > Kotlin: 1.5.31 > > > Groovy: 3.0.9 > > > Ant: Apache Ant(TM) version 1.10.11 compiled on July 10 2021 > > > JVM: 17.0.5 (Eclipse Adoptium 17.0.5+8) > > > OS: Linux 5.15.79.1-microsoft-standard-WSL2 amd64 > > > > > > > java -version > > > openjdk version "17.0.5" 2022-10-18 > > > OpenJDK Runtime Environment Temurin-17.0.5+8 (build 17.0.5+8) > > > OpenJDK 64-Bit Server VM Temurin-17.0.5+8 (build 17.0.5+8, mixed mode, > > > sharing) > > > > > > Francis > > > > > > > > > On 3/02/2023 3:24 pm, Jess Balint wrote: > > > > Hi all, > > > > > > > > I have created a build for Apache Calcite 1.33.0, release > > > > candidate 0. > > > > > > > > Thanks to everyone who has contributed to this release. > > > > > > > > You can read the release notes here: > > > > > > > > > https://github.com/apache/calcite/blob/calcite-1.33.0-rc0/site/_docs/history.md > > > > > > > > The commit to be voted upon: > > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=96b05ee12f936ed057265072ff6a2de8ea0a249e > > > > > > > > Its hash is 96b05ee12f936ed057265072ff6a2de8ea0a249e > > > > > > > > Tag: > > > > > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=tag;h=refs/tags/calcite-1.33.0-rc0 > > > > > > > > The artifacts to be voted on are located here: > > > > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.33.0-rc0 > > > > (revision 59874) > > > > > > > > The hashes of the artifacts are as follows: > > > > > > > > > a4acc084344b48c1e9a61a70fbe8009c8093cafdb8c4f05d646681a5ea15ab79ab90b4c2fc7e410f952239a167001f4021e97c2c0be8f29edb7255015cb8a7c6 > > > > *apache-calcite-1.33.0-src.tar.gz > > > > > > > > A staged Maven repository is available for review at: > > > > > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1199/org/apache/calcite/ > > > > > > > > Release artifacts are signed with the following key: > > > > https://people.apache.org/keys/committer/jbalint.asc > > > > https://www.apache.org/dist/calcite/KEYS > > > > > > > > To create the jars and test Apache Calcite: "gradle build" > > > > (requires an appropriate Gradle/JDK installation) > > > > > > > > Please vote on releasing this package as Apache Calcite 1.33.0. > > > > > > > > The vote is open for the next 72 hours and passes if a majority of at > > > > least three +1 PMC votes are cast. > > > > > > > > [ ] +1 Release this package as Apache Calcite 1.33.0 > > > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > > > [ ] -1 Do not release this package because... > > > > > > > > Here is my vote: > > > > > > > > +1 (binding) > > > > > > > > >
