Agreed. The problem has gone away, so there is no need to fix .ratignore.
On Sun, Feb 19, 2023 at 12:32 AM Benchao Li <[email protected]> wrote: > > I noticed that two PRs[1][2] have updated today, and the CI both passed. > > I also reverted the changes to `.ratignore` in my test branch[3], it passed > too. > > It seems that the failure is ephemeral, and we do not have to modify > `.ratignore` to get rid of it, at least it is not urgent. > > [1] https://github.com/apache/calcite/pull/3055 > [2] https://github.com/apache/calcite/pull/3053 > [3] https://github.com/apache/calcite/pull/3074 > > Julian Hyde <[email protected]> 于2023年2月18日周六 15:29写道： > > > Many thanks for your help, Benchao. I think that modifying .ratignore is a > > good solution. (I may try to find a pattern that is a little more > > restrictive, and merge it tomorrow.) > > > > It’s good to know that I didn’t cause the breakage, and others can safely > > merge if the rat errors are the only errors. > > > > Julian > > > > > On Feb 17, 2023, at 21:55, Benchao Li <[email protected]> wrote: > > > > > > I also spotted this error today. And I did some verification, here are > > some > > > observations: > > > > > > - The CI started failing after two commits[1][2] committed yesterday > > > - I opened a test PR[3] to make sure that the latest main branch still > > > suffers from this, and the result is yes[4] > > > - I reverted the last two commits, and the CI still fails[5] > > > > > > Hence I think this is not related to your commits. Maybe some github > > > actions changed recently, I haven't checked it thoroughly yet. > > > > > > There is a way to get rid of this, we can add the cache path to the > > > `.ratignore` file. I have verified this, the CI passed after I added it > > to > > > the `.ratignore` file[6]. > > > > > > [1] > > > > > https://github.com/apache/calcite/commit/f82028f4b983707bd9af3d9ba73820ef2431e971 > > > [2] > > > > > https://github.com/apache/calcite/commit/baab45c99769cfd1d98f1afd115c301834f1961e > > > [3] https://github.com/apache/calcite/pull/3074 > > > [4] > > > > > https://github.com/apache/calcite/pull/3074/commits/6af7e60a454f2264cf425dc10454d93200249f5a > > > [5] > > > > > https://github.com/apache/calcite/pull/3074/commits/71b9b747c51fc4f108759455923e2e474357e547 > > > [6] > > > > > https://github.com/apache/calcite/pull/3074/commits/5149bc88870ebc59d04d0410689f596b41c7035f > > > > > > > > > Julian Hyde <[email protected]> 于2023年2月18日周六 11:39写道： > > > > > >> CI tests have been falling recently (e.g. [1]) with the following error: > > >> > > >>> Task :rat FAILED > > >> :rat failure marker > > >> Files with unapproved licenses: > > >> - > > >> > > /home/runner/work/calcite/calcite/C:/Users/runneradmin/.gradle-cache-action/gradle-generated-jars-contents.json > > >> - > > >> > > /home/runner/work/calcite/calcite/C:/Users/runneradmin/.gradle-cache-action/gradle-generated-jars-info.json > > >> > > >> The errors follow my changes, but I can't imagine what I could have > > >> done to cause this, and I can't reproduce locally. Any ideas? > > >> > > >> Julian > > >> > > >> [1] > > >> > > https://github.com/apache/calcite/actions/runs/4200311575/jobs/7286200016 > > >> > > > > > > > > > -- > > > > > > Best, > > > Benchao Li > > > > > -- > > Best, > Benchao Li
