+1, we should add it.
Stamatis Zampetakis <zabe...@gmail.com> 于2023年2月21日周二 18:36写道：
It seems that the calcite-1.33.0 tag is missing both from GitHub and
GitBox
remote; I only see calcite-1.33.0-rc0.
Not sure why it is not there but I think we should add it.
Best,
Stamatis
On Thu, Feb 9, 2023 at 10:49 PM Julian Hyde <jhyde.apa...@gmail.com>
wrote:
I said I’d update reporter. Sorry I didn’t get to it.
Jess, Several improvements to history.md were discussed in the PR. Do
you
intend to commit these to main? I was surprised that they weren’t in
the
'Prepare for next development iteration’ commit.
Julian
On Feb 9, 2023, at 6:51 AM, Stamatis Zampetakis <zabe...@gmail.com>
wrote:
Cool then I will use 2023-02-06 in JIRA and update the reporter as
well.
Thanks for the confirmation!
On Thu, Feb 9, 2023 at 3:49 PM Jess Balint <jbal...@gmail.com>
wrote:
Thanks for noticing this Stamatis. I used the release date of
2023-02-06 as
this was when the artifact was published.
* I'm not sure what to do about the downloads page if the date comes
from
the release post
https://calcite.apache.org/news/2023/02/07/release_1.33.0/.
We shouldn't change the URL because it was included in the release
announcement.
* I'm not able to change the status to "release" for 1.33.0 on Jira.
Can
you make the change please?
* Julian said he would update reporter
On Thu, Feb 9, 2023 at 4:33 AM Stamatis Zampetakis <
zabe...@gmail.com
wrote:
The https://reporter.apache.org/ service does not have the 1.33.0
release.
The 1.33.0 release also appears unreleased in JIRA
https://issues.apache.org/jira/projects/CALCITE/versions/12352272
I was planning to fill those in but I am not sure which date to
pick:
* The release date in downloads [1] says 07 Feb 2023.
* The release date in the release notes [2] is 2023-02-06.
* The JIRA closing comment says "Resolved in release 1.33.0
(2023-02-06)"
I am leaning towards 2023-02-06 since it appears in more places.
Best,
Stamatis
[1] https://calcite.apache.org/downloads/
[2] https://calcite.apache.org/docs/history.html#v1-33-0
On Wed, Feb 8, 2023 at 11:28 AM Stamatis Zampetakis <
zabe...@gmail.com
wrote:
Great work Jess, thanks a lot for being the RM!
On Wed, Feb 8, 2023 at 12:57 AM Jess Balint <jbal...@gmail.com>
wrote:
Release is complete and main branch is open for commits! Thanks
for
your
patience.
On Tue, Feb 7, 2023 at 1:42 PM Julian Hyde <
jhyde.apa...@gmail.com
wrote:
The date can be whatever you decide as release manager. It’s
important
that the date in the news item matches, because the downloads
page
is
generated from that. Back in the day I had trouble generating
the
site
when
local date <> UTC date, or when the news item date was in the
future.
When I see you push the web site updates, I’ll update reporter.
Julian
On Feb 7, 2023, at 11:33 AM, Jess Balint <jbal...@gmail.com>
wrote:
I thought it would be the svn commit date mentioned above
(2023-02-06).
Otherwise today works. I'm working on the site updates.
On Tue, Feb 7, 2023 at 1:32 PM Julian Hyde <
jhyde.apa...@gmail.com>
wrote:
Happy to do that.
What’s the release date? We have only ~4 hours left of
2023-02-07
UTC.
On Feb 7, 2023, at 11:27 AM, Jess Balint <jbal...@gmail.com>
wrote:
Can a PMC member please set the release date?
r59936 at 2023-02-06 21:29:21 +0000 (Mon, 06 Feb 2023)
Promoting Apache Calcite calcite-1.33.0-rc0 -> calcite-1.33.0
to
release
area
If you are a PMC member of this project, we ask that you log
on
to:
https://reporter.apache.org/addrelease.html?calcite
and add your release data (version and date) to the database.
On Tue, Feb 7, 2023 at 1:02 PM Julian Hyde <
jhyde.apa...@gmail.com>
wrote:
Jess, Please let us know when main is open.
On Feb 7, 2023, at 8:59 AM, Jess Balint <jbal...@gmail.com
wrote:
I ran it more than once because it failed the first time. I
didn't
realize
there might be side effects. Thanks for the confirmation.
I'll
setup
the
announcement.
On Tue, Feb 7, 2023 at 7:56 AM Stamatis Zampetakis <
zabe...@gmail.com>
wrote:
Strange error; did you run the publishDist task more than
once?
Other than that, I see the release was propagated to the
mirrors[1]
so I
don't think there is anything else pending apart from the
remaining
steps
(announcements etc.).
Best,
Stamatis
[1]
https://dlcdn.apache.org/calcite/apache-calcite-1.33.0/
On Tue, Feb 7, 2023 at 12:36 AM Julian Hyde <
jhyde.apa...@gmail.com
wrote:
It looks as if the directory was successfully moved from
dev
to
release.
(Does anyone know the URL for the dist.apache.org svn
commit
log?)
On Feb 6, 2023, at 1:48 PM, Jess Balint <
jbal...@gmail.com
wrote:
I just tried to publish the release. The files are
present
here:
https://dist.apache.org/repos/dist/release/calcite/apache-calcite-1.33.0/
However the Gradle task failed with the following error.
Is
this
failure
a
problem or is the release fully published?
Thanks.
Jess
Task :publishSvnDist FAILED
Listing SVN folders
[dev/calcite/apache-calcite-1.33.0-rc0]
at
https://dist.apache.org/repos/dist
Build calcite FAILURE reason:
Execution failed for task ':publishSvnDist':
Unable to list folders
[dev/calcite/apache-calcite-1.33.0-rc0]
at
https://dist.apache.org/repos/dist: svn: warning:
W160013:
URL '
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.33.0-rc0
'
non-existent in revision 59936
svn: E200009: Could not list all targets because some
targets
don't
exist
at com.github.vlsi.gradle.release.svn.Svn.ls
(Svn.kt:118)
at
com.github.vlsi.gradle.release.PromoteSvnRelease.operations(PromoteSvnRelease.kt:48)
at
com.github.vlsi.gradle.release.SvnmuccTask.mucc(SvnmuccTask.kt:91)
On Thu, Feb 2, 2023 at 4:03 PM Julian Hyde <
jh...@apache.org
wrote:
Because we like keeping the git history linear. If we
continued
development during a release we would need to make a
git
merge
commit
(for
the release notes at least).
On 2023/02/02 19:38:40 Jess Balint wrote:
Speaking of which, why don't we branch off for the
release
to
avoid
blocking commits?
On Thu, Feb 2, 2023 at 1:29 PM Jess Balint <
jbal...@gmail.com>
wrote:
Sorry for delay! I'll get the release notes PR up in
a
few
hours.
On Thu, Feb 2, 2023 at 1:28 PM Julian Hyde <
jh...@apache.org>
wrote:
Jess,
How long until the RC is ready for a vote?
Main branch has been closed for over a week and it's
hurting.
Julian
On 2023/01/27 23:01:16 Julian Hyde wrote:
The particular failure I was referring to was this
one:
Task :druid:javadoc
Picked up _JAVA_OPTIONS: -XX:GCTimeLimit=90
-XX:GCHeapFreeLimit=35
error: Error fetching URL:
https://docs.oracle.com/en/java/javase/17/docs/api/
(java.net.SocketException: Connection reset)
in the "macOS (JDK 18)" check [1] for the latest
commit,
c4155b8d.
I
have never seen it before, but it looks like
infrastructure.
CALCITE-5501 is a different issue, also
intermittent,
also
not
a
blocker for the release.
Julian
[1]
https://github.com/apache/calcite/actions/runs/4020515767/jobs/6908529265
On Fri, Jan 27, 2023 at 2:22 PM Alessandro
Solimando
<alessandro.solima...@gmail.com> wrote:
Hello,
I think that Julian was referring to CALCITE-5501
<
https://issues.apache.org/jira/browse/CALCITE-5501
for
the
intermittent
CI issue, a PR fixing it is now available.
I have no problem waiting for the release to be
rolled
out
before
merging
it, just wanted to reach out to see if you prefer
to
merge
it
right
away,
in case please let me know.
Btw, thanks Jess for being the release manager!
Best regards,
Alessandro
On Fri, 27 Jan 2023 at 23:09, Jess Balint <
jbal...@gmail.com>
wrote:
Thanks, will get the release notes PR up shortly.
On Thu, Jan 26, 2023 at 7:29 PM Julian Hyde <
jh...@apache.org>
wrote:
I have merged a fix for CALCITE-5489. Thanks to
Tanner
and
TJ
for
their
help.
There is one failure in the build, but I'm
pretty
sure
it
is
intermittent and is related to CI
infrastructure,
not
our
code.
Jess, Go ahead and make that RC.
Julian
On Thu, Jan 26, 2023 at 10:50 AM Julian Hyde <
jhyde.apa...@gmail.com>
wrote:
I tried your PR
https://github.com/apache/calcite/pull/3048/files.
It
fixes the bug, but the test cases you have
included
to
not
reproduce the
bug. I think that TIMESTAMP_DIFF(quarter,
TIMESTAMP
‘…’,
’TIMESTAMP ‘…’)
is
the problematic pattern, but you have tested
TIMESTAMP_DIFF(TIMESTAMP
‘…’,
’TIMESTAMP ‘…’, quarter).
On Jan 26, 2023, at 9:13 AM, Tanner Clary <
tannercl...@google.com
.INVALID>
wrote:
Yes I will be putting up a PR with a fix in
the
next
hour
or
so.
Sorry
about the hold up!
Tanner
On Thu, Jan 26, 2023 at 8:09 AM Julian Hyde <
jhyde.apa...@gmail.com>
wrote:
I agree that this is a blocker.
Sergey’s PR illustrates the problem but
isn’t a
great
fix.
The fix
should
look for “flag” literals in order to
distinguish
between
the
function
variants. The test case should be in a Quidem
test
rather
than
RexBuikderTest.
Tanner, do you have time to work on a revised
PR?
In
any
case I’ll
merge a
fix in the next 8 hours.
Julian
On Jan 26, 2023, at 12:09 AM, Ruben Q L <
rube...@gmail.com>
wrote:
According to our Jira dashboard [1] it
seems
there's
still
one
blocker
issue for 1.33 [2] (it was categorized as
blocker
because
it was a
regression).
I guess we should complete this ticket
before
starting
the
RC.
[1]
https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
[2]
https://issues.apache.org/jira/browse/CALCITE-5489
On Thu, Jan 26, 2023 at 3:44 AM Jess
Balint <
jbal...@gmail.com>
wrote:
Great, I'll start the build. Let's hold off
on
further
commits
please.
On Wed, Jan 25, 2023 at 6:48 PM Julian
Hyde
<
jh...@apache.org>
wrote:
I have merged it:
https://github.com/apache/calcite/commit/20014b6c5b9b57d29248206f19d63ef50f7a5c0f
On Wed, Jan 25, 2023 at 2:03 PM Jess
Balint
<
jbal...@gmail.com>
wrote:
I'll merge it and then start the rc
build.
On Wed, Jan 25, 2023, 13:04 Julian Hyde <
jh...@apache.org>
wrote:
Oops, I have one more PR ready to merge
[1].
If
the
main branch
is
not
yet closed, let me know, Jess.
Julian
[1]
https://issues.apache.org/jira/browse/CALCITE-5283
On Wed, Jan 25, 2023 at 8:14 AM Julian
Hyde <
jhyde.apa...@gmail.com>
wrote:
I agree. I merged some PRs last night
(before
I
saw
this
email)
but I
agree it’s time for an RC. I’ll stop
pushing
to
main.
Have at
it,
Jess!
Julian
On Jan 24, 2023, at 2:03 PM, Stamatis
Zampetakis <
zabe...@gmail.com>
wrote:
Thanks for staying on top of this
Jess!
Apart from the two JIRAs marked as
blockers
(regressions from
1.32.0) I
don't think we should wait much more
for
getting
the
release
out.
Best,
Stamatis
On Tue, Jan 24, 2023 at 10:59 PM Jess
Balint <
jbal...@gmail.com
wrote:
The Avatica release is out. I've done
what I
can
on
outstanding
reviews:
https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
Do we have any final requests for PRs
to
be
merged or
should I
create
the
rc build?
On Sun, Jan 15, 2023 at 2:20 PM
Julian
Hyde <
jh...@apache.org>
wrote:
I have created a jira case to track
this
release:
https://issues.apache.org/jira/browse/CALCITE-5481
Also, I am proposing to make a quick
Avatica
1.23
release.
If
the
plans
work out, it will be ready for
inclusion
in
Calcite
1.33
from
Thursday.
Julian
On 2023/01/05 20:21:03 Julian Hyde
wrote:
Good idea. I have started reviewing
those
two
cases.
Reviewers are still needed for the
other
cases.
Julian
On Jan 5, 2023, at 3:39 AM, Dmitry
Sysolyatin
<
dm.sysolya...@gmail.com>
wrote:
It will be also good to review and
include
to
release
https://issues.apache.org/jira/browse/CALCITE-5405
and
https://issues.apache.org/jira/browse/CALCITE-5407.
I
am
not
familiar
with
mongodb adapter
On Thu, Jan 5, 2023 at 12:24 PM
Stamatis
Zampetakis <
zabe...@gmail.com
wrote:
I added
https://issues.apache.org/jira/browse/CALCITE-2884
to the
list. I
am finalizing the patch right now
and
will
get
this in a
few
hours.
I removed the fixVersion from
https://issues.apache.org/jira/browse/CALCITE-5427
(I
am
working
on
it)
since there is no rush to get it
in
1.33.0.
Unfortunately, I don't have time
to
review
other
things
today.
Best,
Stamatis
On Wed, Jan 4, 2023 at 9:19 PM
Julian
Hyde
<
jhyde.apa...@gmail.com>
wrote:
According to the dashboard [
https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
<
https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
] there are 6 open issues, all
of
which
have
pull
requests.
Can we have volunteers to
review/merge
these in
the
next
24
hours?
As
last
time, I’ll match: if 2 people
take
2
issues
each, I’ll
take
the
last
2.
Julian
On Jan 4, 2023, at 11:30 AM,
Jess
Balint
<
jbal...@gmail.com
wrote:
Happy New Year everyone! I am
going
to do
a RC
build
this
week
if
there
are
no objections.
On Thu, Dec 15, 2022 at 5:27 PM
Bertil
Chapuis
<
bchap...@gmail.com>
wrote:
Hello Everyone,
I just merged CALCITE-5417
after
incorporating
Julian's
feedback. I
believe this was the final
issue
that
needed
to be
resolved
before
the
release.
Thanks a lot to Grigory for
his
help
and
for
releasing
new
versions of
proj4j early and often.
Best,
Bertil
On 15 Dec 2022, at 09:32,
Ruben
Q
L
<
rube...@gmail.com>
wrote:
@Jess I think we should wait
for
[1],
which
is a
cleaner
solution
for
the
Proj4j issue, better than the
initial
quick-fix that
was
committed
some
days ago [2].
The PR seems in a good shape
(thanks
Bertil
and
Julian
for
your
work
in
this one!), and hopefully it
will
be
merged
soon.
@Sean, no, at this moment
there's
no
plan for
Avatica
1.23
release
yet
(so
it will not be included in
Cacite
1.33).
Best,
Ruben
[1]
https://issues.apache.org/jira/browse/CALCITE-5417
[2]
https://issues.apache.org/jira/browse/CALCITE-5399
On Thu, Dec 15, 2022 at 3:14
AM
Sean
Broeder
<
s...@dremio.com
wrote:
Are there plans to release a
new
version of
Avatica(1.23) to
be
included
in Calcite 1.33.0?
Thanks,
Sean
On Dec 14, 2022, at 3:47
PM,
Jess
Balint <
jbal...@gmail.com
wrote:
I have reviewed a few PRs.
The
Proj4j
fix
has been
merged.
Do
we
have
any
more bandwidth for reviews
or
anybody
asking for
reviews?
Otherwise,
I
can
start the RC build soon.
On Mon, Nov 28, 2022 at
6:07
AM
Ruben
Q L <
rube...@gmail.com>
wrote:
Thanks Jess for being RM
of
1.33,
and
thanks
Benchao
for
volunteering
as
RM.
The updated list for
future
releases
will
be as
follows:
- 1.33.0 Jess Balint
- 1.34.0 Duan Xiong
- 1.35.0 Benchao Li
There are currently 14
unresolved
issues
for
1.33:
https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950
Many of them have a PR
available,
let's
try to
do a
collective
effort
and
review them ASAP (I remind
everyone
that
you can
assign a
PR
to
yourself to
let others know that you
are
taking
care
of it).
As I mentioned on the
initial
email,
let's try to
finalize
the
remaining
issues during these two
weeks,
to
see
if
we can
produce a
RC0
by
mid-December.
Regarding the recent
Proj4j
license
problem (
https://issues.apache.org/jira/browse/CALCITE-5399
),
should
we
consider
this a blocking issue for
1.33?
Best,
Ruben
On Fri, Nov 11, 2022 at
6:53
PM
Jess
Balint <
jbal...@gmail.com
wrote:
Hi Ruben,
Thanks for the note. I'm
available
for
RM duty.
Here's the
list
of
issues
currently outstanding:
--
Best,
Benchao Li
