I've opened a ticket for infra: https://issues.apache.org/jira/browse/INFRA-24518
Benchao Li <[email protected]> 于2023年4月23日周日 23:07写道： > Seems that we have reached a consensus to change it back, I'll open a Jira > in infra to change it back if no objections arise in 48 hours. > > Stamatis Zampetakis <[email protected]> 于2023年3月30日周四 17:04写道： > >> It's true that I've never seen a fake PR so far in the ASF repos but >> at the same time I am not following every single PR. >> I can understand the approval for first time contributors but keeping >> the approval for everyone seems a bit too much. >> >> Best, >> Stamatis >> >> On Wed, Mar 29, 2023 at 5:04 AM 王鹏 <[email protected]> wrote: >> > >> > +1 for this. I think it's very friendly to create PR for contributors. >> > >> > Dan Zou <[email protected]> 于2023年3月29日周三 10:13写道： >> > >> > > +1 for this, it is something out of my expectation when I created my >> first >> > > PR in calcite and informed that approval is required. >> > > >> > > Best, >> > > Dan Zou >> > > >> > > >> > > >> > > >> > > >> > > > 2023年3月28日 21:37，Benchao Li <[email protected]> 写道： >> > > > >> > > > I'm +1 for changing it back. >> > > > >> > > > I was also thinking about starting a discussion about this before, >> but I >> > > > didn't know how to achieve it. Thanks Julian for sharing this with >> us. >> > > > >> > > > Julian Hyde <[email protected]> 于2023年3月28日周二 20:57写道： >> > > > >> > > >> (Forwarding from the Druid list for discussion.) >> > > >> >> > > >> Julian >> > > >> >> > > >> Begin forwarded message: >> > > >> >> > > >>> From: Gian Merlino <[email protected]> >> > > >>> Date: March 28, 2023 at 1:24:42 AM CDT >> > > >>> To: [email protected] >> > > >>> Subject: CI requiring approval for external contributors >> > > >>> Reply-To: [email protected] >> > > >>> >> > > >>> Recently, ASF GitHub repos had their defaults for GitHub Actions >> > > >> changed to >> > > >>> "always require approval for external contributors". In Slack, >> Karan >> > > >>> pointed out that Airflow has recently submitted a ticket to have >> that >> > > >>> changed back: https://issues.apache.org/jira/browse/INFRA-24200. >> IMO, >> > > we >> > > >>> should do the same. I don't think we have a problem with fake >> PRs, but >> > > we >> > > >>> can always improve our responsiveness to contributors from >> outside the >> > > >>> project! Every little bit helps, including running CI >> automatically. >> > > >>> >> > > >>> If others have opinions on this, let me know. I'd like to raise >> our own >> > > >>> ticket to change our default. >> > > >>> >> > > >>> Gian >> > > >> >> > > > >> > > > >> > > > -- >> > > > >> > > > Best, >> > > > Benchao Li >> > > >> > > >> > > > -- > > Best, > Benchao Li > -- Best, Benchao Li
