I finished CALCITE-5701 Add NAMED_STRUCT function (enabled in Spark library) I hope it's not too late for the release: https://github.com/apache/calcite/pull/3295
The CI passes, it just needs a re-run on the last commit. On Fri, Jun 30, 2023 at 5:26 PM Gian Merlino <[email protected]> wrote: > Of the open tickets, I reviewed CALCITE-5708 and CALCITE-5727, which are > two I felt I understood well enough to review. > > On 2023/06/28 19:36:16 Julian Hyde wrote: > > I have taken care of 1, 2, 3, 4. > > > > Tanner, can you do 5. > > > > Of the 12 open issues that are open and have fixVersion = 1.35, most > have PRs ready for review [1]. Can a few committers each take say 3 cases > each and review their PRs? > > > > Julian > > > > [1] > https://issues.apache.org/jira/issues/?jql=project%20%3D%20CALCITE%20AND%20fixVersion%20%3D%201.35.0%20and%20status%20%3D%20open > > > > > On Jun 28, 2023, at 6:25 AM, Ruben Q L <[email protected]> wrote: > > > > > > Hello, > > > > > > Thanks for checking Xiong Duan, I have taken care of 6,7,8. > > > > > > Contributors, please remember that after completing a ticket, the Jira > > > needs to be set to "Resolved", not "Closed" (they will be moved to > Closed > > > by the Release Manager, once the next release is produced). > > > > > > Apart from that, our dashboard [1] still shows 22 unresolved tickets > with > > > fixVersion=1.35 > > > Except from the blocker ones, I guess the rest would need to be > resolved > > > shortly or otherwise moved to fixVersion=1.36 (or no fixVersion). > > > As a general rule, please do not set a fixVersion unless it is a > blocker > > > issue, or you're reasonably sure that the issue will be done for the > next > > > release. > > > > > > Best, > > > Ruben > > > > > > [1] > > > > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > > > > > > > > > > > > > > On Wed, Jun 28, 2023 at 1:47 PM xiong duan <[email protected]> > wrote: > > > > > >> In order to release 1.35.0, I reviewed all the fixed issues in this > > >> version, Here are some issue statuses that need to be resolved: > > >> > > >> > > >> 1. https://issues.apache.org/jira/browse/CALCITE-5764(The PR has > > >> merge.But issue is IN PROGRESS). (Assigine Julian Hyde) > > >> 2. https://issues.apache.org/jira/browse/CALCITE-5706(The PR has > > >> merge.But issue is IN PROGRESS). (Assigine Julian Hyde) > > >> 3. https://issues.apache.org/jira/browse/CALCITE-5765(The PR has > > >> merge.But issue is IN PROGRESS). (Assigine Julian Hyde) > > >> 4. https://issues.apache.org/jira/browse/CALCITE-5762(The PR has > > >> merge.But issue is IN PROGRESS). (Assigine Julian Hyde) > > >> 5. https://issues.apache.org/jira/browse/CALCITE-5747(The PR has > > >> merge.But issue is NOT Resolve). (Assigine Tanner Clary) > > >> 6. https://issues.apache.org/jira/browse/CALCITE-5771(The Fix > Version > > >> is > > >> NONE, Need set it to 1.35.0) > > >> 7. https://issues.apache.org/jira/browse/CALCITE-5757(The Fix > Version > > >> is > > >> NONE, Need set it to 1.35.0) > > >> 8. https://issues.apache.org/jira/browse/CALCITE-4679(Resolution > should > > >> be Fixed. But is Resolved) > > >> > > >> If you are busy, Please tell me the real status of the ISSUE, and I > will > > >> handle it. (6,7,8 need one PMC to handle it).Thanks. > > >> > > >> > > >> Jacky Lau <[email protected]> 于2023年6月26日周一 14:24写道： > > >> > > >>> hi @xiong duan: > > >>> thanks for your review and merged very much, and i forgot there > are > > >>> also have one pr https://github.com/apache/calcite/pull/3262 > > >>> do you also have time to have a look？ > > >>> > > >>> > > >>> xiong duan <[email protected]> 于2023年6月25日周日 19:45写道： > > >>> > > >>>> I have reviewed: > > >>>> https://github.com/apache/calcite/pull/3238 > > >>>> https://github.com/apache/calcite/pull/3263 > > >>>> If no other problem, I will merge it tomorrow. > > >>>> > > >>>> Ruben Q L <[email protected]> 于2023年6月25日周日 17:20写道： > > >>>> > > >>>>> I'd like to include CALCITE-5789 in 1.35. I'll try to finalize it > > >>>>> today/tomorrow. > > >>>>> > > >>>>> > > >>>>> > > >>>>> El dom, 25 jun 2023, 6:33, Jacky Lau <[email protected]> > > >> escribió: > > >>>>> > > >>>>>> could we review this pr, so that it could be merged in 1.35. then > > >> the > > >>>>> 1.35 > > >>>>>> will almost have the full spark collection function. > > >>>>>> I would very appreciate a review. if someone has time. > > >>>>>> > > >>>>>> https://github.com/apache/calcite/pull/3238 > > >>>>>> https://github.com/apache/calcite/pull/3263 > > >>>>>> > > >>>>>> xiong duan <[email protected]> 于2023年6月25日周日 10:31写道： > > >>>>>> > > >>>>>>> I have created CALCITE-5797 to release 1.35.0. If there are no > > >>>>>> objections, > > >>>>>>> I will create an RC in the following days. > > >>>>>>> > > >>>>>>> [1]:https://issues.apache.org/jira/browse/CALCITE-5797 > > >>>>>>> > > >>>>>>> If there are other must fix for 1.35.0 please let us know so that > > >>> we > > >>>>> can > > >>>>>>> plan accordingly. > > >>>>>>> > > >>>>>>> Julian Hyde <[email protected]> 于2023年6月24日周六 01:58写道： > > >>>>>>> > > >>>>>>>> We said ‘mid-June’. Time to get this release rolling? > > >>>>>>>> > > >>>>>>>>> On Jun 20, 2023, at 10:34 PM, Gian Merlino <[email protected]> > > >>>>> wrote: > > >>>>>>>>> > > >>>>>>>>> I committed the patch for CALCITE-5477. I would appreciate a > > >>>> review > > >>>>>> on > > >>>>>>>> CALCITE-5479, if someone has a chance. > > >>>>>>>>> > > >>>>>>>>> On 2023/06/07 09:53:08 Gian Merlino wrote: > > >>>>>>>>>> Some more detail: > > >>>>>>>>>> > > >>>>>>>>>> - the PR for CALCITE-5477 is > > >>>>>>>> https://github.com/apache/calcite/pull/3249 > > >>>>>>>>>> - the PR for CALCITE-5479 is > > >>>>>>>> https://github.com/apache/calcite/pull/3030 > > >>>>>>>>>> > > >>>>>>>>>> I've just pushed up some updates to reflect the new approach > > >>> we > > >>>>>>>> discussed for guava backwards-compat in CALCITE-5477, and to > > >> sync > > >>>> up > > >>>>>> with > > >>>>>>>> latest main in CALCITE-5479. > > >>>>>>>>>> > > >>>>>>>>>> We've been doing a bunch of work on the Druid side to be > > >> able > > >>> to > > >>>>>>> update > > >>>>>>>> our Calcite dependency (currently, we're on 1.21.0). From what > > >>>> we've > > >>>>>> seen > > >>>>>>>> so far, we believe if these two patches are part of 1.35.0, > > >> then > > >>> we > > >>>>>> could > > >>>>>>>> target that version. > > >>>>>>>>>> > > >>>>>>>>>> Gian > > >>>>>>>>>> > > >>>>>>>>>> On 2023/06/07 06:32:34 Abhishek Agarwal wrote: > > >>>>>>>>>>> We (Apache Druid) would also like > > >>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5479 and > > >>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5477 to be > > >>> fixed > > >>>>> in > > >>>>>>>> 1.35.0. > > >>>>>>>>>>> There are PRs for both of these fixes. We are working on > > >>>>> addressing > > >>>>>>>> review > > >>>>>>>>>>> comments and just need a few days of time. > > >>>>>>>>>>> > > >>>>>>>>>>> On Thu, Jun 1, 2023 at 3:32 AM Julian Hyde < > > >> [email protected] > > >>>> > > >>>>>> wrote: > > >>>>>>>>>>> > > >>>>>>>>>>>> There's one Jira case we should fix: > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5737 > > >> (support > > >>>> JDK > > >>>>>> 19 > > >>>>>>>> and > > >>>>>>>>>>>> 20). Can someone take that on? > > >>>>>>>>>>>> > > >>>>>>>>>>>> Julian > > >>>>>>>>>>>> > > >>>>>>>>>>>> On 2023/05/30 08:33:23 xiong duan wrote: > > >>>>>>>>>>>>> Yes. I can release 1.35.0 when the PR is handled. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Julian Hyde <[email protected]> 于2023年5月30日周二 05:46写道： > > >>>>>>>>>>>>> > > >>>>>>>>>>>>>> Mid-June sounds like a good idea. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> I would like to see the following Jira cases finished: > > >>>>>>>>>>>>>> * 5701 NAMED_STRUCT (MasseGuillaume) > > >>>>>>>>>>>>>> * 5640 SAFE_ADD (DanZou) > > >>>>>>>>>>>>>> * 5625 SEARCH (olivrlee) > > >>>>>>>>>>>>>> * 5626 Fully-qualified names (herunkang2018) > > >>>>>>>>>>>>>> * 5615 SQL Logic Test (mbudiu) > > >>>>>>>>>>>>>> * 5607 JSON serialization (olivrlee) > > >>>>>>>>>>>>>> * 5564 PERCENTILE_CONT (tanclary) > > >>>>>>>>>>>>>> * 5526 Unparsing literals (TJ Banghart) > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> If the authors have made changes they would like me to > > >>>> review, > > >>>>>>>> please > > >>>>>>>>>>>>>> add a comment to the Jira case. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Any other cases, don't ask me personally, ask everyone > > >> on > > >>>> the > > >>>>>> dev > > >>>>>>>>>>>>>> list. My capacity to review PRs is limited. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Julian > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> On Fri, May 26, 2023 at 11:16 PM Benchao Li < > > >>>>>> [email protected] > > >>>>>>>> > > >>>>>>>>>>>> wrote: > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> It's been a bit more than 2 months since our last > > >> release > > >>>> [1] > > >>>>>> and > > >>>>>>>>>>>> there > > >>>>>>>>>>>>>> are > > >>>>>>>>>>>>>>> currently 80+ new commits in master. > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> As usual, according to our Jira dashboard [2] and > > >> Github > > >>>> [3], > > >>>>>>> there > > >>>>>>>>>>>> are > > >>>>>>>>>>>>>>> many pending issues that could / should be part of the > > >>>>> release. > > >>>>>>> I'd > > >>>>>>>>>>>>>> propose > > >>>>>>>>>>>>>>> to make a collective effort to try to clean up our 1.35 > > >>>>> backlog > > >>>>>>> and > > >>>>>>>>>>>> merge > > >>>>>>>>>>>>>>> the PRs which are in a good state. I'd propose to aim > > >> for > > >>>>> **mid > > >>>>>>>>>>>> June** to > > >>>>>>>>>>>>>>> release 1.35.0, this will give us about 15-20 days to > > >>> clean > > >>>>> up > > >>>>>>>>>>>> pending > > >>>>>>>>>>>>>> PRs > > >>>>>>>>>>>>>>> for next version. What do you think? > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> According to [4], the following release managers would > > >>> be: > > >>>>>>>>>>>>>>> - 1.35.0 Duan Xiong > > >>>>>>>>>>>>>>> - 1.36.0 Benchao Li > > >>>>>>>>>>>>>>> - 1.37.0 Sergey Nuyanzin > > >>>>>>>>>>>>>>> - 1.38.0 Julian Hyde > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> @Duan Xiong, are you still available for being the > > >>> release > > >>>>>>> manager > > >>>>>>>>>>>> for > > >>>>>>>>>>>>>>> 1.35.0? > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> And contributors, if you have any work that is in good > > >>>> shape > > >>>>>> and > > >>>>>>>>>>>> want to > > >>>>>>>>>>>>>> be > > >>>>>>>>>>>>>>> included in 1.35.0, please mark the fixVersion to > > >> 1.35.0, > > >>>>> this > > >>>>>>> will > > >>>>>>>>>>>>>> inform > > >>>>>>>>>>>>>>> the release manager, and we'll try our best to get it > > >> in. > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> [1] > > >> https://calcite.apache.org/docs/history.html#v1-34-0 > > >>>>>>>>>>>>>>> [2] > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>> > > >>>>>>> > > >>>>>> > > >>>>> > > >>>> > > >>> > > >> > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > >>>>>>>>>>>>>>> [3] https://github.com/apache/calcite/pulls > > >>>>>>>>>>>>>>> [4] > > >>>>>>>> > > >> https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> > > >>>>>>>>>>>>>>> Best, > > >>>>>>>>>>>>>>> Benchao Li > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>> > > >>>>>>>> > > >>>>>>> > > >>>>>> > > >>>>> > > >>>> > > >>> > > >> > > > > >
