+1 as this is a regression. Thanks, Gian, for discovering this.
On 20/07/2023 6:36 pm, Ruben Q L wrote:
Thanks Gian for signaling this issue.
Since this is a regression introduced in 1.35 (and it looks more or less
simple to fix) IMO we should cancel the rc2 vote, fix CALCITE-5865 and move
to a rc3.
Best,
Ruben
On Thu, Jul 20, 2023 at 3:29 AM Chunwei Lei <[email protected]> wrote:
Thanks Xiong Duan for being RM for this release.
- Checked release notes on tag: some comments
Some improvements in simplify an expression.
Some improvements in simplifying an expression.
[CALCITE-5717] RelBuilder.project of literals on a single-row `Aggregate`
should create a Values
I think Aggregate should not be quoted since other operators are not quoted
either.
- Checksum: ok
- Signature: ok
- Diff source release and git repository: ok
- Build + tests: ok
Best,
Chunwei
On Thu, Jul 20, 2023 at 7:26 AM Gian Merlino <[email protected]> wrote:
When testing this with Apache Druid we found a problem: the change in
CALCITE-5747 broke a few of our test cases due to this piece:
https://github.com/apache/calcite/pull/3245/files#diff-e873041549333502af52ece8a1b34301ae5a059ff4719e9bddbaef48929e7047L7338-L7341
Essentially, FLOOR and CEIL no longer work with a SqlConformance that is
not a SqlConformanceEnum. (In Druid we have a conformance that extends
SqlAbstractConformance.)
I wrote up a Jira case here:
https://issues.apache.org/jira/browse/CALCITE-5865, and have a patch up
here: https://github.com/apache/calcite/pull/3327
Could we include this fix in 1.35.0? Arguably, since this would be a new
problem in 1.35.0, it should be fixed prior to release.
On 2023/07/17 18:24:21 xiong duan wrote:
Hi all,
I have created a build for Apache Calcite 1.35.0, release
candidate 2.
Thanks to everyone who has contributed to this release.
You can read the release notes here:
https://github.com/apache/calcite/blob/calcite-1.35.0-rc2/site/_docs/history.md
The commit to be voted upon:
https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=2f5635f13a4eb4b89c119fabf25b1d31e0018426
Its hash is 2f5635f13a4eb4b89c119fabf25b1d31e0018426
Tag:
https://github.com/apache/calcite/tree/calcite-1.35.0-rc2
The artifacts to be voted on are located here:
https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.35.0-rc2
(revision 63046)
The hashes of the artifacts are as follows:
b5d837e3725554254bdad0e4f4a63134193a1e3f44bb9b862d9eeeb7f9a5e9bae01985e2f1857874928dc4dbf1f4ca3ae4debacc096470081c249eba699dc74e
*apache-calcite-1.35.0-src.tar.gz
A staged Maven repository is available for review at:
https://repository.apache.org/content/repositories/orgapachecalcite-1213/org/apache/calcite/
Release artifacts are signed with the following key:
https://people.apache.org/keys/committer/xiong.asc
https://www.apache.org/dist/calcite/KEYS
To create the jars and test Apache Calcite: "gradle build"
(requires an appropriate Gradle/JDK installation)
Please vote on releasing this package as Apache Calcite 1.35.0.
The vote is open for the next 72 hours and passes if a majority of at
least three +1 PMC votes are cast.
[ ] +1 Release this package as Apache Calcite 1.35.0
[ ] 0 I don't feel strongly about it, but I'm okay with the release
[ ] -1 Do not release this package because...
Here is my vote:
+1 (binding)
