Ran Tao created CALCITE-5908:
--------------------------------

             Summary: Remove misleading NULL checks in CalciteSchema
                 Key: CALCITE-5908
                 URL: https://issues.apache.org/jira/browse/CALCITE-5908
             Project: Calcite
          Issue Type: Improvement
          Components: core
    Affects Versions: 1.35.0
            Reporter: Ran Tao
            Assignee: Ran Tao


When i read the source code of `CalciteSchema` found so many null checks below:

 
{code:java}
    if (tableMap == null) {
      this.tableMap = new NameMap<>();
    } else {
      this.tableMap = Objects.requireNonNull(tableMap, "tableMap");
    }
    if (latticeMap == null) {
      this.latticeMap = new NameMap<>();
    } else {
      this.latticeMap = Objects.requireNonNull(latticeMap, "latticeMap");
    } {code}
i think we can remove it. it was misleading.

 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to