Thank you for opening this PR, overall looks good,I left a couple of comments!
stanilovsky evgeny <[email protected]> 于2023年9月28日周四 14:16写道： > search for reviewer, can anyone plz ? > > > Guys, plz help with review ? Need >=1 additional eyes ) > > > >> Julian thanks. > >> PR passed all checks and ready for review. > >> > >>> I just took a look at > >>> https://github.com/apache/calcite/pull/3393/checks. I see an autostyle > >>> violation, and it looks valid. That error is there so that you can fix > >>> it and not waste reviewers' time. > >>> > >>> On Wed, Aug 23, 2023 at 2:15 PM Julian Hyde <[email protected]> wrote: > >>>> > >>>> There aren't many false positives or flaky tests in CI, > >>>> checker-framework, error-prone. If it says that (say) you are passing > >>>> a nullable object to a method that requires a not-nullable argument, > >>>> you probably are. > >>>> > >>>> I find it useful to run checker-framework on my own computer, rather > >>>> than waiting for CI. But you must use JDK 11: > >>>> > >>>> ./gradlew --no-parallel --no-daemon -PenableCheckerframework > >>>> :linq4j:classes :core:classes > >>>> > >>>> Julian > >>>> > >>>> On Wed, Aug 23, 2023 at 8:42 AM stanilovsky evgeny > >>>> <[email protected]> wrote: > >>>> > > >>>> > PR is ready for review, plz explain did i need to fix all of: CI / > >>>> > CheckerFramework issues ? > >>>> > Seems some of them are false positive. > >>>> > thanks ! > >>>> > > >>>> > > Evgeny Stanilovsky created CALCITE-5950: >
