thanks Tanner for reviewing it! I will fix the comments/problems ASAP. Best Regards, Ran Tao
Tanner Clary <tannercl...@google.com.invalid> 于2023年10月13日周五 00:10写道： > I added some comments and questions to pull #3459, thanks for > the contributions! > > Tanner > > On Thu, Oct 12, 2023 at 8:27 AM Ran Tao <chucheng...@gmail.com> wrote: > > > Hi community, > > > > I have 2 issues with MAP constructor/function. > > > > In CALCITE-6040, I have fixed a bug of the calcite map constructor when > the > > map meets null key/values in some special cases. > > In CALCITE-5918, I have added a basic Spark MAP function (need additional > > +1 review). > > > > If someone has time, please help me to review this PR, thank you very > much. > > > > [1] CALCITE-6040 > > Jira: https://issues.apache.org/jira/browse/CALCITE-6040 > > PR: https://github.com/apache/calcite/pull/3463 > > > > [2] CALCITE-5918 > > Jira: https://issues.apache.org/jira/browse/CALCITE-5918 > > PR: https://github.com/apache/calcite/pull/3459 > > > > Best Regards, > > Ran Tao > > >
