I don’t think of GitHub’s approval check-box as ‘official’. As a committer, you can decide when you have ’sufficient approval’. If it’s a simple change, no approval is needed. Sometimes I say ‘looks good to go, please add javadoc to class Xyz’ and I would not expect (or want) to re-review.
> On Feb 8, 2024, at 2:25 PM, Mihai Budiu <mbu...@gmail.com> wrote: > > Hi all, > > Several of my PRs have received LGTM, but no official approval. > E.g.,: https://github.com/apache/calcite/pull/3672 > What's the rule about these, can I go ahead and merge them (assuming the LGTM > is from a committer)? There is a trade-off between being sure and pestering > people for yet another review. > > Thank you, > Mihai
