+1 libenchao (PMC member) - verified checksum and signature: OK - diffed files between source and tag: (OK, found that LICENSE file is different between them, which has been spotted by Stamatis in RC0 vote) - build and test using java8 and java23: OK - went over staged maven repo, checked some files and signature: OK - went over the release notes: OK (left one minor comment which could be addressed after the release)
Francis Chuang <francischu...@apache.org> 于2024年10月11日周五 18:27写道: > > My vote is: +1 francischuang (PMC member) > > - Verified GPG signature - OK > - Verified SHA512 - OK > - Diffed source release and git repository - OK > - Checked release notes on tag > (https://github.com/apache/calcite/blob/calcite-1.38.0-rc1/site/_docs/history.md) > - OK > - Checked year and versions in NOTICE, README and HOWTO - OK > - Ran tests (gradle check) - OK > - Spot checked Nexus artifacts - OK > > Environments: > Eclipse-temurin:23 docker container in WSL2 (Ubuntu 22.04.5) on Windows > 11 23h2 > > $ docker version > Client: > Version: 27.2.0 > API version: 1.47 > Go version: go1.21.13 > Git commit: 3ab4256 > Built: Tue Aug 27 14:14:20 2024 > OS/Arch: linux/amd64 > Context: default > > Server: Docker Desktop () > Engine: > Version: 27.2.0 > API version: 1.47 (minimum version 1.24) > Go version: go1.21.13 > Git commit: 3ab5c7d > Built: Tue Aug 27 14:15:15 2024 > OS/Arch: linux/amd64 > Experimental: false > containerd: > Version: 1.7.20 > GitCommit: 8fc6bcff51318944179630522a095cc9dbf9f353 > runc: > Version: 1.1.13 > GitCommit: v1.1.13-0-g58aa920 > docker-init: > Version: 0.19.0 > GitCommit: de40ad0 > > $ gradle -v > > ------------------------------------------------------------ > Gradle 8.7 > ------------------------------------------------------------ > > Build time: 2024-03-22 15:52:46 UTC > Revision: 650af14d7653aa949fce5e886e685efc9cf97c10 > > Kotlin: 1.9.22 > Groovy: 3.0.17 > Ant: Apache Ant(TM) version 1.10.13 compiled on January 4 2023 > JVM: 23 (Eclipse Adoptium 23+37) > OS: Linux 5.15.153.1-microsoft-standard-WSL2 amd64 > > $ java --version > openjdk 23 2024-09-17 > OpenJDK Runtime Environment Temurin-23+37 (build 23+37) > OpenJDK 64-Bit Server VM Temurin-23+37 (build 23+37, mixed mode, sharing) > > Francis > > On 10/10/2024 2:29 pm, Julian Hyde wrote: > > Hi all, > > > > I have created a build for Apache Calcite 1.38.0, release > > candidate 1. > > > > Thanks to everyone who has contributed to this release. > > > > You can read the release notes here: > > https://github.com/apache/calcite/blob/calcite-1.38.0-rc1/site/_docs/history.md > > > > The commit to be voted upon: > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=e5e7faeff5985bc1b2342144b2bd31ca8ea84d3a > > > > Its hash is e5e7faeff5985bc1b2342144b2bd31ca8ea84d3a > > > > Tag: > > https://github.com/apache/calcite/tree/calcite-1.38.0-rc1 > > > > The artifacts to be voted on are located here: > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.38.0-rc1 > > (revision 72241) > > > > The hashes of the artifacts are as follows: > > 3751b8426b772f1eb333320e75c9768cafbecc663cccfd3df016f83d4b70acb34fdb77d60f3f5f990b699d466775e4749f799f8885b502b88e85a313c8b25825 > > *apache-calcite-1.38.0-src.tar.gz > > > > A staged Maven repository is available for review at: > > https://repository.apache.org/content/repositories/orgapachecalcite-1235/org/apache/calcite/ > > > > Release artifacts are signed with the following key: > > https://people.apache.org/keys/committer/jhyde.asc > > https://www.apache.org/dist/calcite/KEYS > > > > To create the jars and test Apache Calcite: "gradle build" > > (Requires an appropriate Gradle/JDK installation.) > > > > Please vote on releasing this package as Apache Calcite 1.38.0. > > Everyone is welcome to vote. Your vote should contain the line > > 'code name (role)', where > > * 'code' is +1, 0 or -1 as below; > > * 'name' is your ASF id if you have one, else your real name; > > * 'role' is 'community', 'committer' or 'PMC member'. > > > > [ ] +1 Release this package as Apache Calcite 1.38.0 > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > [ ] -1 Do not release this package because... > > > > The vote is open for the next 72 hours (closing at > > 2024-10-13 03:00 UTC) and passes if a majority of > > at least three +1 votes by PMC members are cast. > > > > Here is my vote: > > > > +1 jhyde (PMC member) > > > > Julian Hyde (release manager) > -- Best, Benchao Li