Hi Hugh, Thanks for proposing this fix, I took a look and this is good.
Re: the git issues, was your problem with just amending the commit message? If so, maybe https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/changing-a-commit-message is useful. It's also okay to push multiple commits to the same PR and the merging committer will take care to ensure it gets squashed down to a single commit. Let me know if I misunderstood your concern, and thanks again! Tanner On Thu, Jan 23, 2025 at 9:10 AM Hugh Pearse <hughpea...@gmail.com> wrote: > Hello dev team, > I had to close PR #4159 - https://github.com/apache/calcite/pull/4159 > and open a new PR #4162 https://github.com/apache/calcite/pull/4162 > > This was due to using wrong commit message.I had issues with rewriting git > commit history to update commit message to conform with the standard. > Unit test is now passing, and there are no errors or warnings. > Kindly please review when you have the time. > Thank you so much and sorry for the hassle. > > From, > Hugh Pearse > > > > > > On Wed, 22 Jan 2025 at 22:24, Hugh Pearse <hughpea...@gmail.com> wrote: > > > Hi team, > > Kindly please review PR > > https://github.com/apache/calcite/pull/4159 > > > > Thank you so much. > > > > From, > > Hugh Pearse > > > > > > > > >
