I have reverted CALCITE-6978 and finally postponed CALCITE-7009 as I prefer not to rush on it.
Since there are no pending tickets, let's freeze the main branch, I will start preparing the release and it will hopefully be ready by EOD tomorrow (CEST). Best regards, Alessandro On Thu, 22 May 2025 at 19:17, Mihai Budiu <mbu...@gmail.com> wrote: > I think that reverting 6978 is the right call for now. > It is fixing a real bug, but we do not provide an easy workaround yet. > > Mihai > > ________________________________ > From: Alessandro Solimando <alessandro.solima...@gmail.com> > Sent: Thursday, May 22, 2025 5:36 AM > To: dev@calcite.apache.org <dev@calcite.apache.org> > Subject: Re: Apache Calcite 1.40.0 release > > Hello, > CALCITE-7035 <https://issues.apache.org/jira/browse/CALCITE-7035> has just > been filed which reports a regression due to CALCITE-6978 > <https://issues.apache.org/jira/browse/CALCITE-6978>, which is part of > 1.40.0. > > I haven't looked at it in detail, so I can't judge if it can be fixed > quickly or not. > I have pinged Mihai in the ticket as the author of the change in > CALCITE-6978 <https://issues.apache.org/jira/browse/CALCITE-6978>, but I > will try to have a look too in the meantime. > > If the fix is complex, I propose to revert CALCITE-6978 > <https://issues.apache.org/jira/browse/CALCITE-6978> for 1.40.0 and > address > both in the next release. > Please share your thoughts if you see this differently or if you have > better suggestions. > > Best regards, > Alessandro > > On Wed, 21 May 2025 at 12:13, Alessandro Solimando < > alessandro.solima...@gmail.com> wrote: > > > @Konstantin: thank you for the reminder on CALCITE-7009 > > <https://issues.apache.org/jira/browse/CALCITE-7009>, I have just > > approved the associated PR #4378 > > <https://github.com/apache/calcite/pull/4378>, I will merge it in ~24 > > hours if there are no objections by then. I am not an expert for > > correlation but your reasoning in the ticket is detailed and convincing, > > and I have tested against PostgreSQL and the expected result matches. > > > > @Mihai: > > #4328 <https://github.com/apache/calcite/pull/4328> for CALCITE-5638 > > <https://issues.apache.org/jira/browse/CALCITE-5638> has been merged > > (thanks suibianwanwank!) > > > > #4382 <https://github.com/apache/calcite/pull/4382> for CALCITE-7017 > > <https://issues.apache.org/jira/browse/CALCITE-7017> was dependent on > > CALCITE-5638 <https://issues.apache.org/jira/browse/CALCITE-5638> and > can > > probably be finalized, I have pinged the author, let's see if we can make > > it in the next two days (we also need a code comment on the change, as > you > > requested). I will put the fixVersion=1.40.0 to not forget it, but I > > don't consider it blocking for the release, I will remove it if we run > out > > of time (unless someone objects). > > > > Thanks for resolving CALCITE-7014 > > <https://issues.apache.org/jira/browse/CALCITE-7014>, and I saw your > > comment for CALCITE-7026 > > <https://issues.apache.org/jira/browse/CALCITE-7026>, it seems it will > > require a bit more discussion. > > > > CALCITE-7027 <https://issues.apache.org/jira/browse/CALCITE-7027> is > > indeed ready to be merged if Julian is OK with the updated Jira title > > (which LGTM btw). > > > > CALCITE-7030 <https://issues.apache.org/jira/browse/CALCITE-7030> has > > been resolved in the meantime (thanks Nobigo!). > > > > There is also CALCITE-6887 > > <https://issues.apache.org/jira/browse/CALCITE-6887> / #4371 > > <https://github.com/apache/calcite/pull/4371>, I need to take another > > look as some comments were scattered over the three PRs. There is an > > approval from a committer already (thanks Zhen Chen!) but you have made > > some comments Mihai, maybe you can take another look. > > > > All pending tickets surely identified for 1.40.0 are here: > > > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > > > Best regards, > > Alessandro > > > > > > On Wed, 21 May 2025 at 08:15, Xiong Duan <xi...@apache.org> wrote: > > > >> I have merged and resolved 7030. > >> > >> Konstantin Orlov <kor...@apache.org> 于2025年5月21日周三 14:04写道： > >> > > >> > Folks, any chance to include > >> > https://issues.apache.org/jira/browse/CALCITE-7009 in the upcoming > >> > release? The patch is really small, we only need to find someone with > >> good > >> > expertise in correlates to take a look. > >> > > >> > -- > >> > Regards, > >> > Konstantin Orlov > >> > > >> > On Tue, May 20, 2025 at 7:45 PM Alessandro Solimando < > >> > alessandro.solima...@gmail.com> wrote: > >> > > >> > > Hi everyone, > >> > > as announced, I would like to close the main branch in roughly 48 > >> hours > >> > > from now and start preparing the RC for the next release. > >> > > > >> > > According to this dashboard > >> > > < > >> > > > >> > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > >> > > >, > >> > > there are only two unresolved tickets marked for 1.40.0: > >> > > - CALCITE-7014 <https://issues.apache.org/jira/browse/CALCITE-7014 > >, > >> which > >> > > didn't receive any comments so far and I feel like it can be moved > to > >> > > 1.41.0 > >> > > - CALCITE-6887 <https://issues.apache.org/jira/browse/CALCITE-6887 > >, > >> > > already an approval from a committer and close to completion IMO > >> > > > >> > > These three tickets have good enough already associated PRs and can > >> easily > >> > > make it into the release, although they don't have a fixVersion set, > >> at the > >> > > moment: > >> > > - CALCITE-7026 <https://issues.apache.org/jira/browse/CALCITE-7026> > >> > > - CALCITE-7027 <https://issues.apache.org/jira/browse/CALCITE-7027> > >> > > - CALCITE-7030 <https://issues.apache.org/jira/browse/CALCITE-7030> > >> > > > >> > > Is there anything else that we might want to try to squeeze in into > >> 1.40.0? > >> > > > >> > > Best regards, > >> > > Alessandro > >> > > > >> > > Best regards, > >> > > Alessandro > >> > > > >> > > On Fri, 16 May 2025 at 09:57, Stamatis Zampetakis < > zabe...@gmail.com> > >> > > wrote: > >> > > > >> > > > Having a new release by June would be great! Thanks for starting > the > >> > > > discussion Alessandro! > >> > > > > >> > > > I will start a separate thread for the signing party. Let's > discuss > >> > > > here any must have items for the release and/or issues encountered > >> > > > during the process. > >> > > > > >> > > > Best, > >> > > > Stamatis > >> > > > > >> > > > On Thu, May 15, 2025 at 10:42 AM Alessandro Solimando > >> > > > <alessandro.solima...@gmail.com> wrote: > >> > > > > > >> > > > > Thank you, Francis, for your quick reply, I will make sure to > >> reach out > >> > > > in > >> > > > > case of problems :) > >> > > > > > >> > > > > Good point regarding the tz, I am located in CEST/GMT+2. > >> > > > > > >> > > > > If someone within my same timezone is available it's easier, but > >> > > > otherwise > >> > > > > I can adapt to the tz of whoever is available for the key > signing. > >> > > > > > >> > > > > Best regards, > >> > > > > Alessandro > >> > > > > > >> > > > > On Thu, 15 May 2025 at 10:27, Francis Chuang < > >> francischu...@apache.org > >> > > > > >> > > > > wrote: > >> > > > > > >> > > > > > +1 I think this is a good plan. > >> > > > > > > >> > > > > > For the signing party, can you please let us know which > timezone > >> > > you're > >> > > > > > in? There should be someone on this list who is in the same > >> timezone > >> > > > and > >> > > > > > can sign your key. > >> > > > > > > >> > > > > > The instructions for making a RC[1] is pretty complete, but if > >> you > >> > > run > >> > > > > > into any issues or have any questions, please post here and we > >> can > >> > > > help! :) > >> > > > > > > >> > > > > > Francis > >> > > > > > > >> > > > > > [1] > >> > > > > >> https://calcite.apache.org/docs/howto.html#making-a-release-candidate > >> > > > > > > >> > > > > > On 15/05/2025 5:36 pm, Alessandro Solimando wrote: > >> > > > > > > Hello, > >> > > > > > > I volunteered to be the next release manager for 1.40.0, > and I > >> > > would > >> > > > like > >> > > > > > > to propose the 24th-25th May as the target date for the RC. > >> > > > > > > > >> > > > > > > To this effect, I'd like to close modifications to the main > >> branch > >> > > a > >> > > > few > >> > > > > > > days before, say the 22nd of May, and take the time until > >> then to > >> > > > > > finalize > >> > > > > > > pending work that should be included into the next release. > >> > > > > > > > >> > > > > > > I haven't participated in any signing party so far, so by > >> then I > >> > > will > >> > > > > > need > >> > > > > > > to have my PGP key signed by someone before the release > >> process > >> > > > starts. > >> > > > > > > Shall we organize a full fledged key signing party or is > >> there some > >> > > > > > > lightweight process we could favor in the interest of time? > >> > > > > > > > >> > > > > > > Please let me know if you have any concerns with the > timeline > >> > > and/or > >> > > > > > > suggestions for the key signing or anything else, as it's my > >> first > >> > > > time > >> > > > > > as > >> > > > > > > release manager, any form of guidance/tip is welcome! > >> > > > > > > > >> > > > > > > Best regards, > >> > > > > > > Alessandro > >> > > > > > > > >> > > > > > > >> > > > > > > >> > > > > >> > > > >> > > >
