Hi all, Julian, on CALCITE-7736 you offered to approve the change once it was ready. It is ready now: https://github.com/apache/calcite/pull/5213 I will merge it after you say OK.
Since my October 11 mail: - Ruben reviewed the PR on October 13 and found real defects, including CALCITE-7734 changes lost in a rebase and new NullPointerExceptions in the adapters. I fixed all of them and added tests that pass nulls. - The fixes that change behavior moved out of the PR and are in main now, each with its own JIRA: CALCITE-7853 (a lambda with no parameters), CALCITE-7948 and CALCITE-7949 (Piglet and PigTable). CALCITE-7852 (Geode) waits in #5325, which Ruben approved. - What is left in the PR is what nullness checking needs: annotations, null checks where a value can really be null, and the build changes. - CALCITE-7947 tracks the build workaround for jspecify/jspecify#795, as Ruben suggested. The PR has 64 commits, one area per commit, and each of them compiles, so you can review it commit by commit and git bisect works across it. I will merge the commits as they are. There's a way to make git ignore "import statements" and package-info.java files in the diff: git diff -I '^(import .*|[[:space:]]+)$' origin/main...origin/pr-5213 -- . ':(exclude)**/package-info.java' Ruben, if you have time for another look at the current version, I would appreciate it. Vladimir
