On Jan 9, 2015, at 1:10 PM, Vladimir Sitnikov <[email protected]> wrote:
> Here's first cut of Vagrant + librarian-puppet + puppet = mongodb > (zips, foodmart) + mysql (foodmart) + postgresql (foodmart): > https://github.com/apache/incubator-calcite/pull/41 > > Please give it a try. Trying it now… > What is the way to populate mongodb then? > I am afraid mongoimport does not support hsqldb input files. > > Main problem: the input data sets are _not_ stable. > For instance, zips.json evolved from 29467 to 29353 rows. > > I believe we need to fix the data into a stable artifact somehow. Yes. Let’s just take a snapshot of zips and use that going forward. Put it into your maven branch for now. We’ll move it into a maven artifact before we commit your changes to master. > >> “mvn test” is, and should remain, the gold standard > > Please see how I modified mongo tests in my vagrant PR: i moved mongo > tests to integration-test phase, so `mvn test` does _not_ launch > those, while `mvn verify` tries to hit mongo. > > I think it is a good separation, so we can make > mongodb/mysql/postgresql tests enabled by default provided the tests > are run in integration-test phase. The idea of integration tests is basically OK. But: 1. Is there a way to move a test from regular to integration without moving/copying code (e.g. by adding an annotation?) We might want to move a test to integration for performance reasons. I don’t want to move/copy code for that. 2. This will mean that 90% or more of tests in an adapter are flagged integration tests. Doesn’t seem quite right. 3. The databases (hsqldb, mysql, postgres) are a special case. We want to run the regular tests (i.e. the ones in core that use the JDBC adapter) three times over. We can’t declare those as integration tests. They should be declared as parameterized tests. And before you say it, I don’t think we should disable the JDBC tests by default. I think that JDBC is a very convenient source of reasonable-sized data sets to exercise the core module. Treating JDBC as “just another adapter” would be purity for purity’s sake. Julian
